Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node-ws): ws wasn't created when upgrade process is async #959

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(node-ws): ws wasn't created when upgrade process is async #959

wants to merge 2 commits into from
+8 −3

Conversation

nakasyou
Copy link
Contributor

@nakasyou nakasyou commented Feb 5, 2025 •
edited
Loading

Fixes #954

The author should do the following, if applicable

  • Add tests
  • Run tests
  • yarn changeset at the top of this repo and push the changeset
  • Follow the contribution guide

@nakasyou nakasyou mentioned this pull request Feb 5, 2025
Open
@yusukebe
Copy link
Member

yusukebe commented Feb 6, 2025

Hi @nakasyou

Thank you for the PR. I tried it and can confirm the problem was solved with this fix. But can you add a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Awaiting in the upgradeWebSocket callback prevents the websocket events from being registered correctly
2 participants
@nakasyou @yusukebe