Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression after logging changes #19935

Closed
hrydgard opened this issue Feb 1, 2025 · 7 comments · Fixed by #19940 or #19943
Closed

Regression after logging changes #19935

hrydgard opened this issue Feb 1, 2025 · 7 comments · Fixed by #19940 or #19943
Milestone
v1.19.0

Comments

@hrydgard
Copy link
Owner

hrydgard commented Feb 1, 2025 •
edited
Loading

Reported by Henrique and Verymelon on Discord. Affects at least Pangya Golf and Test Drive.

First break : v1.18.1-984
Last work : v1.18.1-979

So it's somewhere in #19932.
@hrydgard hrydgard added this to the v1.19.0 milestone Feb 1, 2025
@sum2012
Copy link
Collaborator

sum2012 commented Feb 2, 2025

Test for Pangya Golf
Git bisect result:
b763cb3

@hrydgard
Copy link
Owner Author

hrydgard commented Feb 2, 2025

Thanks, that's convenient :) I'll fix it shortly.

@hrydgard hrydgard mentioned this issue Feb 2, 2025
Merged
@hrydgard
Copy link
Owner Author

hrydgard commented Feb 2, 2025

please post here if #19940 didn't fix it, as I can't test right now.

@sum2012
Copy link
Collaborator

sum2012 commented Feb 2, 2025

Unluck didn't fix.

@sum2012 sum2012 reopened this Feb 2, 2025
@sum2012
Copy link
Collaborator

sum2012 commented Feb 2, 2025

So, it didn't correctly handle
"%08x=sceDisplaySetFrameBuf(%s): must change latched framebuf first" | std::string
Image

@hrydgard
Copy link
Owner Author

hrydgard commented Feb 3, 2025

Thanks, that's great! I know what the problem is now, fix coming up.

(next time: build in debug mode for even better info in the "Locals" window :) )

hrydgard added a commit that referenced this issue Feb 3, 2025
@hrydgard
Second attempt at fixing #19935
d39655f 
Fixes #19935. Forgot to update the formatting for the reporting case.

I'll clean this up in a more general way later, I don't like how this code currently looks.
@hrydgard hrydgard mentioned this issue Feb 3, 2025
Merged
@hrydgard
Copy link
Owner Author

hrydgard commented Feb 3, 2025

Forgot to update the formatting in the hle*Report case, this should now work.

Formatting strings are nasty things... especially when used dynamically like this. I'm gonna clean this code up better later.

hrydgard added a commit that referenced this issue Feb 3, 2025
@hrydgard
Merge pull request #19943 from hrydgard/another-log-fix
e809414 
Second attempt at fixing #19935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.19.0
2 participants
@hrydgard @sum2012