Perl::Critic updates

petdance · petdance · commit 8729b9c6f509 · 2007-03-02T05:53:02.000Z
diff --git a/MANIFEST b/MANIFEST
@@ -1,6 +1,7 @@
 Changes
 Makefile.PL
 MANIFEST
+perlcriticrc
 
 bin/mech-dump
 
diff --git a/Makefile.PL b/Makefile.PL
@@ -115,7 +115,7 @@ tags:
 		--languages=Perl --langmap=Perl:+.t \
 
 critic:
-	perlcritic -1 .
+	perlcritic -1 -q -profile perlcriticrc bin/ lib/ t/
 
 MAKE_FRAG
 }
diff --git a/perlcriticrc b/perlcriticrc
@@ -0,0 +1,27 @@
+[-CodeLayout::ProhibitParensWithBuiltins]
+[CodeLayout::ProhibitHardTabs]
+allow_leading_tabs = 0
+ 
+[-CodeLayout::RequireTidyCode]
+
+[-ControlStructures::ProhibitPostfixControls]
+
+[-Documentation::RequirePodAtEnd]
+[-Documentation::RequirePodSections]
+
+[-Editor::RequireEmacsFileVariables]
+[-ErrorHandling::RequireCarping]
+
+[-InputOutput::ProhibitInteractiveTest]
+[-InputOutput::ProhibitBacktickOperators]
+
+[-Miscellanea::RequireRcsKeywords]
+
+[-Modules::RequireVersionVar]
+
+[-RegularExpressions::RequireExtendedFormatting]
+[-RegularExpressions::RequireLineBoundaryMatching]
+
+[-ValuesAndExpressions::ProhibitEmptyQuotes]
+
+[-Variables::ProhibitPunctuationVars]
diff --git a/t/form-parsing.t b/t/form-parsing.t
@@ -9,7 +9,7 @@ my $base = 'http://localhost/';
 my $content = do { local $/ = undef; <DATA> };
 
 my $forms = [ HTML::Form->parse( $content, $base ) ];
-is( scalar @$forms, 1, 'Find one form, please' );
+is( scalar @{$forms}, 1, 'Find one form, please' );
 
 __DATA__
 <html>
diff --git a/t/form_with_fields.t b/t/form_with_fields.t
@@ -26,13 +26,13 @@ ok( $mech->success, "Fetched $uri" ) or die q{Can't get test page};
 {
     my $form = $mech->form_with_fields(qw/1b/);
     isa_ok( $form, 'HTML::Form' );
-    is($form->attr('name'), '1st_form'); 
+    is($form->attr('name'), '1st_form', 'first form matches');
 }
 
 {
     my $form = $mech->form_with_fields('1b', 'opt[2]');
     isa_ok( $form, 'HTML::Form' );
-    is($form->attr('name'), '2nd_form'); 
+    is($form->attr('name'), '2nd_form', 'second form matches');
 }
 
 {

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ tags:`
`115`	`115`	`--languages=Perl --langmap=Perl:+.t \`
`116`	`116`
`117`	`117`	`critic:`
`118`		`- perlcritic -1 .`
	`118`	`+ perlcritic -1 -q -profile perlcriticrc bin/ lib/ t/`
`119`	`119`
`120`	`120`	`MAKE_FRAG`
`121`	`121`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,13 +26,13 @@ ok( $mech->success, "Fetched $uri" ) or die q{Can't get test page};`
`26`	`26`	`{`
`27`	`27`	`my $form = $mech->form_with_fields(qw/1b/);`
`28`	`28`	`isa_ok( $form, 'HTML::Form' );`
`29`		`- is($form->attr('name'), '1st_form');`
	`29`	`+ is($form->attr('name'), '1st_form', 'first form matches');`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`{`
`33`	`33`	`my $form = $mech->form_with_fields('1b', 'opt[2]');`
`34`	`34`	`isa_ok( $form, 'HTML::Form' );`
`35`		`- is($form->attr('name'), '2nd_form');`
	`35`	`+ is($form->attr('name'), '2nd_form', 'second form matches');`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`{`