Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The e2e tests have implicit dependencies #1413

Open
severo opened this issue Jun 21, 2023 · 3 comments
Open

The e2e tests have implicit dependencies #1413

severo opened this issue Jun 21, 2023 · 3 comments
Labels
P2 Nice to have tests

Comments

@severo
Copy link
Collaborator

severo commented Jun 21, 2023

As reported by @albertvillanova for example, the following test does not pass

$ TEST_PATH=tests/test_11_api.py::test_rows_endpoint make test

while this ones pass:

$ TEST_PATH="tests/test_11_api.py::test_endpoint tests/test_11_api.py::test_rows_endpoint" make test

It's because test_rows_endpoint requires the parquet files to exist, and we implicitly rely on the fact that they have been created in tests/test_11_api.py::test_endpoint.

Other implicit dependency is when we test is-valid and valid.

@severo severo added the tests label Jun 21, 2023
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@severo
Copy link
Collaborator Author

severo commented Jul 21, 2023

keep open

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@severo severo added the P2 Nice to have label Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Nice to have tests
Projects
None yet
Development

No branches or pull requests

1 participant