You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.
Please note that issues that do not follow the contributing guidelines are likely to be ignored.
Currently, all job runners that depend on
JobRunnerWithCache
and use thecache_subdirectory
field, need to do validation before using the generated value like here https://github.com/huggingface/datasets-server/pull/1296/files#diff-d9a2c828d7feca3b7f9e332e040ef861e842a16d18276b356461d2aa34396a8aR248We need a better way to prevent using
None
values given thatJobRunnerWithCache
has https://github.com/huggingface/datasets-server/blob/main/services/worker/src/worker/job_runners/_job_runner_with_cache.py#L23cache_subdirectory: Optional[Path]
.If the
pre_compute
method is not run, job runner children could fail because of non-existing directory.@severo suggested adding a test on each job runner implementation of
JobRunnerWithCache
to ensure the validation is done.The text was updated successfully, but these errors were encountered: