[LoRA training] add aspect ratio bucketing #11438
Open
+234
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sayakpaul
reviewed
May 2, 2025
|
@bot /style |
|
Style fixes have been applied. View the workflow run here. |
asomoza
reviewed
Jul 16, 2025
| repeats=args.repeats, | ||
| center_crop=args.center_crop, | ||
| ) | ||
|
|
||
| batch_sampler = BucketBatchSampler(train_dataset, batch_size=args.train_batch_size, drop_last=False) |
There was a problem hiding this comment.
just curious, why is the drop_last not True here? in this other PR this is set to True so it doesn't error when the batch size is > 1 and the last batch does not have enough images.
There was a problem hiding this comment.
thank for pointing it out! replied in #11921
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support multi-aspect training