fix(release): reject dispatch script injection

Author: hyfdev

.github/workflows/publish-core.yml

@@ -41,7 +41,9 @@ jobs:
           cache: false
           install: false
       - name: Create release plan
-        run: node tools/release/plan.ts --group core --bump "${{ inputs.bump }}" --output release-plan.json
+        env:
+          RELEASE_BUMP: ${{ inputs.bump }}
+        run: node tools/release/plan.ts --group core --bump "$RELEASE_BUMP" --output release-plan.json
       - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
         with:
           name: core-release-plan

.github/workflows/publish-yoga.yml

@@ -41,7 +41,9 @@ jobs:
           cache: false
           install: false
       - name: Create release plan
-        run: node tools/release/plan.ts --group yoga --bump "${{ inputs.bump }}" --output release-plan.json
+        env:
+          RELEASE_BUMP: ${{ inputs.bump }}
+        run: node tools/release/plan.ts --group yoga --bump "$RELEASE_BUMP" --output release-plan.json
       - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
         with:
           name: yoga-release-plan

tools/release/check-config.ts

@@ -63,6 +63,13 @@ for (const group of Object.values(releaseGroups)) {
   assert(workflow.includes("id-token: write"));
   assert.equal(workflow.match(/id-token: write/g)?.length, 1);
   assert(workflow.includes(`tools/release/plan.ts --group ${group.name}`));
+  assert.equal(
+    /^\s*run:.*\$\{\{\s*inputs\./m.test(workflow),
+    false,
+    `${group.workflow} must pass dispatch inputs through step environment variables`,
+  );
+  assert(workflow.includes("RELEASE_BUMP: ${{ inputs.bump }}"));
+  assert(workflow.includes('--bump "$RELEASE_BUMP"'));
   assert.equal(workflow.includes("NODE_AUTH_TOKEN"), false);
   assert.equal(workflow.includes("cache: true"), false);
   for (const match of workflow.matchAll(/^\s*- uses: (?<action>[^\s#]+).*$/gm)) {