Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes, flag stripes are obscured because the OS logo is missing lines #85

Open
1 task done
pandaninjas opened this issue Feb 5, 2023 · 2 comments
Open
1 task done

Comments

@pandaninjas
Copy link
Contributor

pandaninjas commented Feb 5, 2023

Description

  • Does this issue still occur in the master branch?

The pink part of the flag gets obscured because the ascii Zorin OS logo doesn't have any characters in those lines.
image

@hykilpikonna
Copy link
Owner

Thanks for reporting the issue! In this specific case for Zorin, you can use a vertical alignment instead (you can use hyfetch -c to reconfigure the color alignment)

image

As for a general fix, I honestly don't know how this can be effectively fixed programmatically without a lot of manual edge cases, but I'm happy to accept any ideas!

@pandaninjas
Copy link
Contributor Author

Thanks for reporting the issue! In this specific case for Zorin, you can use a vertical alignment instead (you can use hyfetch -c to reconfigure the color alignment)

image

As for a general fix, I honestly don't know how this can be effectively fixed programmatically without a lot of manual edge cases, but I'm happy to accept any ideas!

A general fix might be to discount empty lines for flag calculations. However, it might make the flag look weird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants