MdnsBrowser not declared compilation error in CLI tools when ENABLE_MDNS is false

[dmas11]

• I confirm that this is an issue rather than a question.

Bug report

MdnsBrowser not declared compilation error in CLI tools when ENABLE_MDNS is false

Steps to reproduce

1. Configure cmake without MDNS support (e.g. missing dependencies, causing ENABLE_MDNS=OFF)
2. Run make
3. Compile fails at hyperion-remote.cpp (and all subsequent CLI tools) at the MdnsBrowser::isMdns check.

What is expected?

The if (MdnsBrowser::isMdns(hostName)) block should be guarded by #ifdef ENABLE_MDNS, matching the #include guards at the top of the files. The codebase should compile successfully even when ENABLE_MDNS is false.

What is actually happening?

The build fails with an error: 'MdnsBrowser' has not been declared.

This occurs because MdnsBrowser::isMdns(hostName) is called directly without being wrapped in an #ifdef ENABLE_MDNS block, even though the header #include <mdns/MdnsBrowser.h> is properly #ifdef guarded at the top of the files.

Files affected:

• src/hyperion-remote/hyperion-remote.cpp
• src/hyperion-drm/hyperion-drm.cpp
• src/hyperion-framebuffer/hyperion-framebuffer.cpp
• src/hyperion-v4l2/hyperion-v4l2.cpp
• src/hyperion-x11/hyperion-x11.cpp
• src/hyperion-xcb/hyperion-xcb.cpp
• src/hyperion-aml/hyperion-aml.cpp
• src/hyperion-dispmanx/hyperion-dispmanx.cpp
• src/hyperion-osx/hyperion-osx.cpp
• src/hyperion-qt/hyperion-qt.cpp

Proposed fix:
Wrap the block in all 10 files like so:

#ifdef ENABLE_MDNS
if (MdnsBrowser::isMdns(hostName)) {
    NetUtils::discoverMdnsServices("...");
}
#endif

System

[Lord-Grey]

@dmas11 Thank you for reporting the issue identified.

This might be a left over from some refactoring done before.

I think the better fix might even be removing the MdnsBrowser::isMdns(hostName) check, as NetUtils::discoverMdnsServices will handle the ENABLE_MDNS transparently.

So code would be

	Info(log, "Connecting to Hyperion host: %s, port: %u", QSTRING_CSTR(hostName), port);
	NetUtils::discoverMdnsServices("jsonapi");
	if (!NetUtils::convertMdnsToIp(log, hostName, port))
	{

Plus on the top following code would be removed too (SSDPDiscover is not executed anyway),

#ifdef ENABLE_MDNS
// mDNS discover
#include <mdns/MdnsBrowser.h>
#else
// ssdp discover
#include <ssdp/SSDPDiscover.h>
#endif

[Lord-Grey]

@dmas11 I provided a fix via #2025.
Would you mind testing that the build and code works for you now?