Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

Consider deprecating LinkSettings accessor in Link #429

Open
sappenin opened this issue Feb 1, 2020 · 1 comment
Open

Consider deprecating LinkSettings accessor in Link #429

sappenin opened this issue Feb 1, 2020 · 1 comment
Labels
dependencies Pull requests that update a dependency file ilp-link question

Comments

@sappenin
Copy link
Contributor

sappenin commented Feb 1, 2020

The Link abstraction requires a LinkSettings, but it doesn't appear to be used in AbstractLink nor in IlpOverHttpLink. This is a good indicator that maybe we can remove this class, or else require this in the Constructor of each Link.
@sappenin sappenin added question dependencies Pull requests that update a dependency file ilp-link labels Feb 1, 2020
@sappenin sappenin added wontfix and removed wontfix labels Aug 14, 2020
@sappenin
Copy link
Contributor Author

sappenin commented Aug 14, 2020 •
edited
Loading

Note for posterity: AccountSettings can have a map of custom-settings, but these are not necessary in a Link. Instead, each particular Link should require whatever it requires, and the LinkFactory is responsible for constructing the Link properly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file ilp-link question
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sappenin