Merge pull request #176 from suchapalaver/fix/fix-bug-in-commit-store-get-batch-by-transaction-method

vaporos · web-flow · commit 3fb31f4a489a · 2023-10-10T14:37:07.000-04:00
Fix bug in commit_store get_batch_by_transaction
diff --git a/libsawtooth/src/journal/commit_store.rs b/libsawtooth/src/journal/commit_store.rs
@@ -324,7 +324,7 @@ impl CommitStore {
                     .batches()
                     .iter()
                     .find(|batch| {
-                        !batch
+                        batch
                             .transactions()
                             .iter()
                             .any(|txn| txn.header_signature() == transaction_id)
diff --git a/libsawtooth/src/transact/database/lmdb.rs b/libsawtooth/src/transact/database/lmdb.rs
@@ -533,9 +533,9 @@ mod tests {
         })
     }
 
-    fn run_test<T>(test: T) -> ()
+    fn run_test<T>(test: T)
     where
-        T: FnOnce(&str) -> () + panic::UnwindSafe,
+        T: FnOnce(&str) + panic::UnwindSafe,
     {
         let dbpath = temp_db_path();
 

Original file line number	Diff line number	Diff line change
`@@ -533,9 +533,9 @@ mod tests {`
`533`	`533`	`})`
`534`	`534`	`}`
`535`	`535`
`536`		`- fn run_test<T>(test: T) -> ()`
	`536`	`+ fn run_test<T>(test: T)`
`537`	`537`	`where`
`538`		`- T: FnOnce(&str) -> () + panic::UnwindSafe,`
	`538`	`+ T: FnOnce(&str) + panic::UnwindSafe,`
`539`	`539`	`{`
`540`	`540`	`let dbpath = temp_db_path();`
`541`	`541`