CIP-0082 (Daml draft) - 5% development fund impl #3086

jose-velasco-ieu · 2025-11-05T16:29:39Z

📝 PR Summary

This draft PR proposes Daml changes related to CIP-0082 — Establish a 5% Development Fund.

⚠️ Disclaimer

No tests have been implemented yet.
This PR is not production-ready.
Pre-commit checks were skipped.

Pull Request Checklist

Cluster Testing

If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

Include any change that might be observable by our partners or affect their deployment in the release notes.
Specify fixed issues with Fixes #n, and mention issues worked on using #n
Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

meiersi-da

Thanks. Nice work!

wdyt about doing the change wrt where the configs are stored, and then implementing the Daml tests before pinging for another review?

meiersi-da · 2025-11-06T08:25:12Z

daml/splice-amulet/daml/Splice/AmuletConfig.daml

+-- See Splice.Scripts.Parameters for concrete values.
+data DevelopmentFundConfig = DevelopmentFundConfig
+  with
+    beneficiary : Party


with this design it makes sense to not have to specify a beneficiary at all times. This can be useful to decouple the time when the fund issuance is activated from the time when the collection and funds management rules are setup and implemented.

I'd thus suggest that we make the party optional here.

daml/splice-amulet/daml/Splice/AmuletConfig.daml

meiersi-da · 2025-11-06T08:34:58Z

daml/splice-amulet/daml/Splice/AmuletRules.daml

              issueValidatorRewards = True
-        executeTransfer rewardsConfig context dso transfer
+            configUsd = getValueAsOf now configSchedule
+        executeTransfer rewardsConfig context dso configUsd.developmentFundConfig transfer


avoid repeatedly reading the config. Instead extend:

splice/daml/splice-amulet/daml/Splice/AmuletRules.daml

Lines 760 to 766 in 2fbbe30

data TransferContextSummary = TransferContextSummary with

featuredAppProvider : Optional Party

config : TransferConfig Amulet

openRound : OpenMiningRound

issuingMiningRounds : Map Round IssuingMiningRound

validatorRights : Map Party (ContractId ValidatorRight)

deriving (Eq, Show)

with the config you need.

Actually, if we put developmentFundBeneficiary into the TransferConfig record, then we already get its value at exactly the right place. That should simplify the code quite a bit.

I'd then put the developmentFundPercentage into the IssuanceConfig where we also define all the tranches.

Just to double-check: with this new approach, DevelopmentFundConfig is gone, right?

meiersi-da · 2025-11-06T08:37:11Z

daml/splice-amulet/daml/Splice/AmuletRules.daml

-        let params = computeIssuingRoundParameters
-              miningRound.tickDuration miningRound.amuletPrice miningRound.issuanceConfig summary
+        let
+          optDevelopmentFundPercentage = (.percentage) <$> (getValueAsOf now configSchedule).developmentFundConfig


We generally try to pin all parameters for a round as part of round creation to avoid surprises when issuance configs change.

With my proposal above of putting developmentFundPercentage into IssuanceConfig you get this for free.

daml/splice-amulet/daml/Splice/AmuletRules.daml

daml/splice-amulet/daml/Splice/Issuance.daml

daml/splice-dso-governance/daml/Splice/DsoRules.daml

daml/splice-amulet/daml/Splice/Amulet.daml

jose-velasco-ieu · 2025-11-06T10:54:17Z

and then implementing the Daml tests

Are you referring to implementing the full Daml test suite to cover all the new scenarios?
@meiersi-da

meiersi-da · 2025-11-06T12:20:30Z

and then implementing the Daml tests

Are you referring to implementing the full Daml test suite to cover all the new scenarios? @meiersi-da

yes

Signed-off-by: Jose Velasco - IEU <[email protected]>

…ate a DevelopmentFundCoupon contract in AmuletRules_MiningRound_StartIssuing Signed-off-by: Jose Velasco - IEU <[email protected]>

Signed-off-by: Jose Velasco - IEU <[email protected]>

Co-authored-by: Simon Meier <[email protected]> Signed-off-by: Jose Velasco - IEU <[email protected]>

Signed-off-by: Jose Velasco - IEU <[email protected]>

…n from collection and fund management setup Signed-off-by: Jose Velasco - IEU <[email protected]>

…ntFundPercentage and TransferConfig.optDevelopmentFundBeneficiary Signed-off-by: Jose Velasco - IEU <[email protected]>

Signed-off-by: Jose Velasco - IEU <[email protected]>

…igChange test Signed-off-by: Jose Velasco - IEU <[email protected]>

…figChange test Signed-off-by: Jose Velasco - IEU <[email protected]>

Signed-off-by: Jose Velasco - IEU <[email protected]>

jose-velasco-ieu · 2025-11-11T16:26:09Z

and then implementing the Daml tests

Are you referring to implementing the full Daml test suite to cover all the new scenarios? @meiersi-da

yes

Done
I think it's ready for a second review

jose-velasco-ieu had a problem deploying to ci-forks November 5, 2025 16:29 — with GitHub Actions Error

github-actions bot assigned isegall-da, martinflorian-da and ray-roestenburg-da Nov 5, 2025

jose-velasco-ieu had a problem deploying to ci-forks November 5, 2025 16:52 — with GitHub Actions Error

meiersi-da reviewed Nov 6, 2025

View reviewed changes

jose-velasco-ieu had a problem deploying to ci-forks November 6, 2025 09:46 — with GitHub Actions Error

jose-velasco-ieu had a problem deploying to ci-forks November 6, 2025 10:22 — with GitHub Actions Error

jose-velasco-ieu had a problem deploying to ci-forks November 6, 2025 10:41 — with GitHub Actions Error

jose-velasco-ieu had a problem deploying to ci-forks November 6, 2025 10:43 — with GitHub Actions Error

jose-velasco-ieu had a problem deploying to ci-forks November 6, 2025 10:44 — with GitHub Actions Error

jose-velasco-ieu had a problem deploying to ci-forks November 6, 2025 10:45 — with GitHub Actions Error

jose-velasco-ieu had a problem deploying to ci-forks November 6, 2025 10:47 — with GitHub Actions Error

jose-velasco-ieu had a problem deploying to ci-forks November 6, 2025 10:50 — with GitHub Actions Error

jose-velasco-ieu had a problem deploying to ci-forks November 6, 2025 15:02 — with GitHub Actions Error

jose-velasco-ieu and others added 12 commits November 6, 2025 15:09

cip-82: add DevelopmentFundCoupon template

8ae6f81

Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: add DevelopmentFundConfig to AmuletConfig

59ebaa5

Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: add InputDevelopmentFundCoupon to TransferInput

33acab3

Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: update comment

c9eab5e

Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: remove round from DevelopmentFundCoupon

e259389

Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: add AmuletRules_MergeDevelopmentFundCoupons

adf3d4d

Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: add DsoRules_MergeDevelopmentFundCoupons

a8f2c02

Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: change issuance computation to deduct the fund issuance + cre…

634cfd1

…ate a DevelopmentFundCoupon contract in AmuletRules_MiningRound_StartIssuing Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: add note

85008e8

Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: naming

50350b4

Signed-off-by: Jose Velasco - IEU <[email protected]>

Update daml/splice-amulet/daml/Splice/AmuletConfig.daml

7cea94f

Co-authored-by: Simon Meier <[email protected]> Signed-off-by: Jose Velasco - IEU <[email protected]>

Update daml/splice-amulet/daml/Splice/AmuletRules.daml

6d53cff

Co-authored-by: Simon Meier <[email protected]> Signed-off-by: Jose Velasco - IEU <[email protected]>

jose-velasco-ieu and others added 11 commits November 6, 2025 15:09

Update daml/splice-amulet/daml/Splice/Issuance.daml

c123209

Co-authored-by: Simon Meier <[email protected]> Signed-off-by: Jose Velasco - IEU <[email protected]>

Update daml/splice-amulet/daml/Splice/Issuance.daml

1a2f55c

Co-authored-by: Simon Meier <[email protected]> Signed-off-by: Jose Velasco - IEU <[email protected]>

Update daml/splice-amulet/daml/Splice/Issuance.daml

a7fd0f0

Co-authored-by: Simon Meier <[email protected]> Signed-off-by: Jose Velasco - IEU <[email protected]>

Update daml/splice-dso-governance/daml/Splice/DsoRules.daml

0cde44e

Co-authored-by: Simon Meier <[email protected]> Signed-off-by: Jose Velasco - IEU <[email protected]>

Update daml/splice-dso-governance/daml/Splice/DsoRules.daml

38e2d1e

Co-authored-by: Simon Meier <[email protected]> Signed-off-by: Jose Velasco - IEU <[email protected]>

Update daml/splice-dso-governance/daml/Splice/DsoRules.daml

dcf118e

Co-authored-by: Simon Meier <[email protected]> Signed-off-by: Jose Velasco - IEU <[email protected]>

Update daml/splice-amulet/daml/Splice/Amulet.daml

d9998bb

Co-authored-by: Simon Meier <[email protected]> Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: fix daml build (DsoRules_MergeDevelopmentFundCoupons)

7792e40

Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: refine documentation to remove references to config fields

a5c8c67

Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: make beneficiary optional to decouple fund issuance activatio…

f5d9b43

…n from collection and fund management setup Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: replace DevelomentFundConfig with IssuanceConfig.optDevelopme…

d3561be

…ntFundPercentage and TransferConfig.optDevelopmentFundBeneficiary Signed-off-by: Jose Velasco - IEU <[email protected]>

jose-velasco-ieu force-pushed the josevelasco/cip-82-daml-draft branch from 6569272 to d3561be Compare November 6, 2025 15:12

jose-velasco-ieu had a problem deploying to ci-forks November 6, 2025 15:12 — with GitHub Actions Error

jose-velasco-ieu added 7 commits November 10, 2025 13:13

cip-82: add unit test for issuance with 5% development fund

91dbe44

Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: add optDevelopmentFundPercentage value to testAmuletRulesConf…

9c083e6

…igChange test Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: add optDevelopmentFundBeneficiary value to testAmuletRulesCon…

ba38837

…figChange test Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: add initDevNetWithAmuletConfig test helper

9d683eb

Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: test merging of Development Fund coupons

ecad0f3

Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82 - minor fix in comments/error message

c7ca25b

Signed-off-by: Jose Velasco - IEU <[email protected]>

cip-82: add test for InputDevelopmentFundCoupon

3995ea6

Signed-off-by: Jose Velasco - IEU <[email protected]>

jose-velasco-ieu requested a deployment to ci-forks November 11, 2025 16:23 — with GitHub Actions Waiting

jose-velasco-ieu requested a review from meiersi-da November 11, 2025 16:26

	data TransferContextSummary = TransferContextSummary with
	featuredAppProvider : Optional Party
	config : TransferConfig Amulet
	openRound : OpenMiningRound
	issuingMiningRounds : Map Round IssuingMiningRound
	validatorRights : Map Party (ContractId ValidatorRight)
	deriving (Eq, Show)

CIP-0082 (Daml draft) - 5% development fund impl #3086

Are you sure you want to change the base?

CIP-0082 (Daml draft) - 5% development fund impl #3086

Conversation

jose-velasco-ieu commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 PR Summary

⚠️ Disclaimer

Pull Request Checklist

Cluster Testing

PR Guidelines

Merge Guidelines

Uh oh!

meiersi-da left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jose-velasco-ieu commented Nov 6, 2025

Uh oh!

meiersi-da commented Nov 6, 2025

Uh oh!

jose-velasco-ieu commented Nov 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jose-velasco-ieu commented Nov 5, 2025 •

edited

Loading