Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract useful Fabric proto utils into a separate Go module #3786

Closed
jt-nti opened this issue Nov 16, 2022 · 5 comments
Closed

Extract useful Fabric proto utils into a separate Go module #3786

jt-nti opened this issue Nov 16, 2022 · 5 comments

Comments

@jt-nti
Copy link
Member

jt-nti commented Nov 16, 2022

From @davidkhala hyperledger/fabric-protos-go#10

It is a awesome direction that we split protobuf out from fabric itself.
Meanwhie in second development, fabric-protos-go is used frequently along with powerful tool github.com/hyperledger/fabric/protoutil
Would you consider also migrate github.com/hyperledger/fabric/protoutil to somewhere in github.com/hyperledger/fabric-protos-go

Perhaps fabric-lib-go would be a good home, and some thought about what to move is probably required since protoutil is currently a bit of a mixed bag.

@bestbeforetoday
Copy link
Member

Any capability extracted out to a separate repository should probably also operate on fabric-protos-go-apiv2, not on fabric-protos-go.

@jt-nti
Copy link
Member Author

jt-nti commented Nov 16, 2022

It would definitely be preferable to use apiv2 but I think that depends on where/when it gets extracted, and what consumes the separate module, e.g. fabric-lib-go would probably need to use the old bindings until other components catch up.

@davidkhala
Copy link
Contributor

@jt-nti @bestbeforetoday Any progres on this issue? Or did I miss something great?

@bestbeforetoday
Copy link
Member

As far as I know, nobody is working on this. Somebody else might have better information.

@davidkhala
Copy link
Contributor

davidkhala commented Dec 20, 2023

@jt-nti @bestbeforetoday I have some free time to pick up this task recently, starting from here https://github.com/davidkhala/fabric-protoutil/, I copy the protoutil package to here and trying to isolating it from fabric core as much as possible.

Welcome comment on direction
@denyeart Dave, would you mind moving this to a github discussion?

@hyperledger hyperledger locked and limited conversation to collaborators Jan 16, 2024
@denyeart denyeart converted this issue into discussion #4608 Jan 16, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants