BFT Block Puller: a common block verifier #4408
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
BFT Block Puller: a common block verifier to the peer the orderer.
The new implementation verifies the integrity and signatures of a block stream, while keeping a copy of the latest configuration.
Every time a config block arrives, it must first be verified using VerifyBlock and then used as an argument to the UpdateConfig method.
The block stream could be composed of either:
In both cases, config blocks must arrive in full.
This commit also moved
BlockVerifierAssembler
formorderer/common/cluster/util.go
tocommon/deliverclient/verifier_assembler.go
, as it is now used by both orderer and peer. In addition,VerificationRegistry
was removed fromorderer/common/cluster/util.go
as it is no longer in use.Related issues
#4346