From a8a314f9777416bad7a7bb0ab2967bb4714c4d97 Mon Sep 17 00:00:00 2001 From: Enrique Lacal Date: Tue, 1 Apr 2025 11:20:53 +0100 Subject: [PATCH] fix: subscriptions historical filtering - a subscription always has a transport Signed-off-by: Enrique Lacal --- internal/events/event_manager.go | 2 -- internal/events/event_manager_test.go | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/internal/events/event_manager.go b/internal/events/event_manager.go index 9a57bda107..32ea04dce3 100644 --- a/internal/events/event_manager.go +++ b/internal/events/event_manager.go @@ -311,8 +311,6 @@ func (em *eventManager) QueueBatchRewind(batchID *fftypes.UUID) { } func (em *eventManager) FilterHistoricalEventsOnSubscription(ctx context.Context, events []*core.EnrichedEvent, sub *core.Subscription) ([]*core.EnrichedEvent, error) { - // Transport must be provided for validation, but we're not using it for event delivery so fake the transport - sub.Transport = "websockets" subscriptionDef, err := em.subManager.parseSubscriptionDef(ctx, sub) if err != nil { return nil, err diff --git a/internal/events/event_manager_test.go b/internal/events/event_manager_test.go index ac06c88c08..b1e4e16e62 100644 --- a/internal/events/event_manager_test.go +++ b/internal/events/event_manager_test.go @@ -664,6 +664,7 @@ func TestEventFilterOnSubscriptionMatchesEventType(t *testing.T) { } subscription := &core.Subscription{ + Transport: "websockets", Filter: core.SubscriptionFilter{ Events: core.EventTypeIdentityConfirmed.String(), },