Fix force unwrapping

Author: vadymmarkov

.swiftlint.yml

@@ -3,6 +3,8 @@ included: # paths to include during linting. `--path` is ignored if present.
 excluded: # paths to ignore during linting. Takes precedence over `included`.
   - Carthage
   - Pods
+disabled_rules:
+  - type_name
 
 # configurable rules can be customized from this configuration file
 # binary rules can set their severity level

Cartfile.resolved

@@ -1,2 +1,2 @@
 github "krzyzanowskim/CryptoSwift" "0.6.0"
-github "hyperoslo/Cache" "f4f1398fe02c762630a802b5e5ae9c334beafed9"
+github "hyperoslo/Cache" "0246e9e9e8faae93f2c83d15824789577f4720bf"

Sources/Shared/Fetcher.swift

@@ -7,15 +7,15 @@ class Fetcher {
     case failure(Error)
   }
 
-  enum Error {
+  enum Failure: Error {
     case invalidResponse
     case invalidStatusCode
     case invalidData
     case invalidContentLength
     case conversionError
   }
 
-  let URL: Foundation.URL
+  let url: URL
   var task: URLSessionDataTask?
   var active = false
 
@@ -25,8 +25,8 @@ class Fetcher {
 
   // MARK: - Initialization
 
-  init(URL: Foundation.URL) {
-    self.URL = URL
+  init(url: URL) {
+    self.url = url
   }
 
   // MARK: - Fetching
@@ -37,40 +37,42 @@ class Fetcher {
     DispatchQueue.global(qos: DispatchQoS.QoSClass.background).async { [weak self] in
       guard let weakSelf = self, weakSelf.active else { return }
 
-      weakSelf.task = weakSelf.session.dataTask(with: weakSelf.URL, completionHandler: {
+      weakSelf.task = weakSelf.session.dataTask(with: weakSelf.url, completionHandler: {
         [weak self] data, response, error -> Void in
 
         guard let weakSelf = self, weakSelf.active else { return }
 
         if let error = error {
-          weakSelf.complete { completion(.failure(error as! Fetcher.Error)) }
+          weakSelf.complete { completion(.failure(error)) }
           return
         }
 
         guard let httpResponse = response as? HTTPURLResponse else {
-          weakSelf.complete { completion(.failure(Error.invalidResponse)) }
+          weakSelf.complete { completion(.failure(Failure.invalidResponse)) }
           return
         }
 
         guard httpResponse.statusCode == 200 else {
-          weakSelf.complete { completion(.failure(Error.invalidStatusCode)) }
+          weakSelf.complete { completion(.failure(Failure.invalidStatusCode)) }
           return
         }
 
         guard let data = data, httpResponse.validateLength(data) else {
-          weakSelf.complete { completion(.failure(Error.invalidContentLength)) }
+          weakSelf.complete { completion(.failure(Failure.invalidContentLength)) }
           return
         }
 
         guard let decodedImage = Image.decode(data) else {
-          weakSelf.complete { completion(.failure(Error.conversionError)) }
+          weakSelf.complete { completion(.failure(Failure.conversionError)) }
           return
         }
 
         let image = preprocess(decodedImage)
 
         if weakSelf.active {
-          weakSelf.complete { completion(Result.success(image)) }
+          weakSelf.complete {
+            completion(Result.success(image))
+          }
         }
       })
 

Sources/Shared/ImageView+Imaginary.swift

@@ -4,15 +4,15 @@ public typealias Preprocess = (Image) -> Image
 
 extension ImageView {
 
-  public func setImage(_ URL: Foundation.URL?,
+  public func setImage(_ url: URL?,
                        placeholder: Image? = nil,
                        preprocess: @escaping Preprocess = { image in return image },
                        completion: ((Image?) -> ())? = nil) {
     image = placeholder
 
-    guard let URL = URL else { return }
+    guard let url = url else { return }
 
-    let key = URL.absoluteString
+    let key = url.absoluteString
 
     if let fetcher = fetcher {
       fetcher.cancel()
@@ -35,7 +35,7 @@ extension ImageView {
         Configuration.preConfigure?(weakSelf)
       }
 
-      weakSelf.fetcher = Fetcher(URL: URL)
+      weakSelf.fetcher = Fetcher(url: url)
 
       weakSelf.fetcher?.start(preprocess) { [weak self] result in
         guard let weakSelf = self else { return }

Sources/iOS/Decompressor.swift

@@ -5,25 +5,27 @@ struct Decompressor {
   static func decompress(_ data: Data, scale: CGFloat = 1) -> Image {
     guard let image = Image(data: data) else { return Image() }
 
-    let imageRef = image.cgImage
+    guard let imageRef = image.cgImage, let colorSpaceRef = imageRef.colorSpace else {
+      return image
+    }
 
-    if imageRef?.alphaInfo != .none { return image }
+    if imageRef.alphaInfo != .none { return image }
 
-    let colorSpaceRef = imageRef?.colorSpace
-    let width = imageRef?.width
-    let height = imageRef?.height
+    let width = imageRef.width
+    let height = imageRef.height
     let bytesPerPixel: Int = 4
-    let bytesPerRow: Int = bytesPerPixel * width!
+    let bytesPerRow: Int = bytesPerPixel * width
     let bitsPerComponent: Int = 8
 
     let context = CGContext(data: nil,
-                                        width: width!,
-                                        height: height!,
-                                        bitsPerComponent: bitsPerComponent,
-                                        bytesPerRow: bytesPerRow,
-                                        space: colorSpaceRef!,
-                                        bitmapInfo: CGBitmapInfo().rawValue)
-    context?.draw(imageRef!, in: CGRect(x: 0, y: 0, width: CGFloat(width!), height: CGFloat(height!)))
+                            width: width,
+                            height: height,
+                            bitsPerComponent: bitsPerComponent,
+                            bytesPerRow: bytesPerRow,
+                            space: colorSpaceRef,
+                            bitmapInfo: CGBitmapInfo().rawValue)
+
+    context?.draw(imageRef, in: CGRect(x: 0, y: 0, width: CGFloat(width), height: CGFloat(height)))
 
     guard let imageRefWithoutAlpha = context?.makeImage() else {
       return image

Sources/iOS/Drawers/Drawers.swift

@@ -11,18 +11,22 @@ public struct TintDrawer: ImageDrawer {
   }
 
   public func draw(_ image: UIImage, context: CGContext, rect: CGRect) {
+    guard let cgImage = image.cgImage else {
+      return
+    }
+
     context.setBlendMode(.normal)
     UIColor.black.setFill()
     context.fill(rect)
 
     context.setBlendMode(.normal)
-    context.draw(image.cgImage!, in: rect)
+    context.draw(cgImage, in: rect)
 
     context.setBlendMode(.color)
     tintColor.setFill()
     context.fill(rect)
 
     context.setBlendMode(.destinationIn)
-    context.draw(image.cgImage!, in: rect)
+    context.draw(cgImage, in: rect)
   }
 }