Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the inconsistent error log #16

Closed
anujgoyal1 opened this issue Jan 22, 2021 · 0 comments · Fixed by #34
Closed

Fix the inconsistent error log #16

anujgoyal1 opened this issue Jan 22, 2021 · 0 comments · Fixed by #34
Assignees
Labels
bug Something isn't working

Comments

@anujgoyal1
Copy link
Contributor

anujgoyal1 commented Jan 22, 2021

if (seenContexts.add(context) && !ConfigServiceUtils.isNull(config)) {
        contextSpecificConfigList
            .add(ContextSpecificConfig.newBuilder().setContext(context).setConfig(config).build());
}

in getAllConfig method of DocumentConfigStore, if value of config is null, an error is thrown.
But deleteConfig itself sets the value config in of deletedVersion to null.
So if deleteConfig is called followed by getAllConfigs, it's end up throwing error.

@anujgoyal1 anujgoyal1 added the bug Something isn't working label Jan 22, 2021
@GurtejSohi GurtejSohi self-assigned this Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants