Skip to content

Commit 1597f9e

Browse files
authored
chore: add long and boolean array attribute type (#162)
1 parent 5998726 commit 1597f9e

File tree

5 files changed

+20
-2
lines changed

5 files changed

+20
-2
lines changed

hypertrace-core-graphql-attribute-store/src/main/java/org/hypertrace/core/graphql/attributes/AttributeModelTranslator.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
package org.hypertrace.core.graphql.attributes;
22

33
import static org.hypertrace.core.attribute.service.v1.AttributeKind.TYPE_BOOL;
4+
import static org.hypertrace.core.attribute.service.v1.AttributeKind.TYPE_BOOL_ARRAY;
45
import static org.hypertrace.core.attribute.service.v1.AttributeKind.TYPE_DOUBLE;
56
import static org.hypertrace.core.attribute.service.v1.AttributeKind.TYPE_DOUBLE_ARRAY;
67
import static org.hypertrace.core.attribute.service.v1.AttributeKind.TYPE_INT64;
8+
import static org.hypertrace.core.attribute.service.v1.AttributeKind.TYPE_INT64_ARRAY;
79
import static org.hypertrace.core.attribute.service.v1.AttributeKind.TYPE_STRING;
810
import static org.hypertrace.core.attribute.service.v1.AttributeKind.TYPE_STRING_ARRAY;
911
import static org.hypertrace.core.attribute.service.v1.AttributeKind.TYPE_STRING_MAP;
@@ -33,6 +35,8 @@ public class AttributeModelTranslator {
3335
.put(TYPE_STRING_MAP, AttributeModelType.STRING_MAP)
3436
.put(TYPE_STRING_ARRAY, AttributeModelType.STRING_ARRAY)
3537
.put(TYPE_DOUBLE_ARRAY, AttributeModelType.DOUBLE_ARRAY)
38+
.put(TYPE_BOOL_ARRAY, AttributeModelType.BOOLEAN_ARRAY)
39+
.put(TYPE_INT64_ARRAY, AttributeModelType.LONG_ARRAY)
3640
.build();
3741

3842
public Optional<AttributeModel> translate(AttributeMetadata attributeMetadata) {

hypertrace-core-graphql-attribute-store/src/main/java/org/hypertrace/core/graphql/attributes/AttributeModelType.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,7 @@ public enum AttributeModelType {
88
TIMESTAMP,
99
STRING_MAP,
1010
STRING_ARRAY,
11-
DOUBLE_ARRAY
11+
DOUBLE_ARRAY,
12+
LONG_ARRAY,
13+
BOOLEAN_ARRAY;
1214
}

hypertrace-core-graphql-common-schema/src/main/java/org/hypertrace/core/graphql/common/schema/attributes/AttributeType.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ public enum AttributeType {
1111
TIMESTAMP,
1212
STRING_MAP,
1313
STRING_ARRAY,
14-
DOUBLE_ARRAY;
14+
DOUBLE_ARRAY,
15+
LONG_ARRAY,
16+
BOOLEAN_ARRAY;
1517

1618
public static final String TYPE_NAME = "AttributeType";
1719
}

hypertrace-core-graphql-common-schema/src/main/java/org/hypertrace/core/graphql/common/utils/attributes/AttributeTypeConverter.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
package org.hypertrace.core.graphql.common.utils.attributes;
22

33
import static org.hypertrace.core.graphql.attributes.AttributeModelType.BOOLEAN;
4+
import static org.hypertrace.core.graphql.attributes.AttributeModelType.BOOLEAN_ARRAY;
45
import static org.hypertrace.core.graphql.attributes.AttributeModelType.DOUBLE;
56
import static org.hypertrace.core.graphql.attributes.AttributeModelType.DOUBLE_ARRAY;
67
import static org.hypertrace.core.graphql.attributes.AttributeModelType.LONG;
8+
import static org.hypertrace.core.graphql.attributes.AttributeModelType.LONG_ARRAY;
79
import static org.hypertrace.core.graphql.attributes.AttributeModelType.STRING;
810
import static org.hypertrace.core.graphql.attributes.AttributeModelType.STRING_ARRAY;
911
import static org.hypertrace.core.graphql.attributes.AttributeModelType.STRING_MAP;
@@ -28,6 +30,8 @@ public class AttributeTypeConverter implements Converter<AttributeModelType, Att
2830
.put(STRING_MAP, AttributeType.STRING_MAP)
2931
.put(STRING_ARRAY, AttributeType.STRING_ARRAY)
3032
.put(DOUBLE_ARRAY, AttributeType.DOUBLE_ARRAY)
33+
.put(LONG_ARRAY, AttributeType.LONG_ARRAY)
34+
.put(BOOLEAN_ARRAY, AttributeType.BOOLEAN_ARRAY)
3135
.build();
3236

3337
@Override

hypertrace-core-graphql-common-schema/src/test/java/org/hypertrace/core/graphql/common/utils/attributes/AttributeTypeConverterTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,11 @@ void testConvert() {
3434
assertEquals(
3535
AttributeType.DOUBLE_ARRAY,
3636
attributeTypeConverter.convert(AttributeModelType.DOUBLE_ARRAY).blockingGet());
37+
assertEquals(
38+
AttributeType.LONG_ARRAY,
39+
attributeTypeConverter.convert(AttributeModelType.LONG_ARRAY).blockingGet());
40+
assertEquals(
41+
AttributeType.BOOLEAN_ARRAY,
42+
attributeTypeConverter.convert(AttributeModelType.BOOLEAN_ARRAY).blockingGet());
3743
}
3844
}

0 commit comments

Comments
 (0)