Skip to content

Commit 306eaa4

Browse files
authored
šŸ› Fix spring boot smoke test taking a long time, set more sensible default for OPA endpoint (#343)
* ✨ set default OPA endpoint to localhost * ⚔ set timeoout on waitForTraces
1 parent 9319d3e commit 306eaa4

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

ā€Žotel-extensions/src/main/java/org/hypertrace/agent/otel/extensions/config/HypertraceConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ private HypertraceConfig() {}
5454

5555
static final String DEFAULT_SERVICE_NAME = "unknown";
5656
static final String DEFAULT_REPORTING_ENDPOINT = "http://localhost:4317";
57-
static final String DEFAULT_OPA_ENDPOINT = "http://opa.traceableai:8181/";
57+
static final String DEFAULT_OPA_ENDPOINT = "http://localhost:8181/";
5858
static final int DEFAULT_OPA_POLL_PERIOD_SECONDS = 30;
5959
// 128 KiB
6060
static final int DEFAULT_BODY_MAX_SIZE_BYTES = 128 * 1024;

ā€Žsmoke-tests/src/test/java/org/hypertrace/agent/smoketest/AbstractSmokeTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import io.opentelemetry.proto.trace.v1.InstrumentationLibrarySpans;
2323
import io.opentelemetry.proto.trace.v1.Span;
2424
import java.io.IOException;
25+
import java.time.Duration;
2526
import java.util.Collection;
2627
import java.util.concurrent.TimeUnit;
2728
import java.util.concurrent.atomic.AtomicLong;
@@ -162,6 +163,7 @@ protected static Stream<InstrumentationLibrarySpans> getInstrumentationLibSpanSt
162163

163164
protected Collection<ExportTraceServiceRequest> waitForTraces(final int count) {
164165
return Awaitility.await()
166+
.atMost(Duration.ofSeconds(10))
165167
.until(
166168
this::waitForTraces,
167169
exportTraceServiceRequests -> exportTraceServiceRequests.size() == count);

0 commit comments

Comments
Ā (0)