Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPC Instrumentation not adding rpc.body to spans #313

Closed
shashank11p opened this issue May 5, 2021 · 2 comments · Fixed by #322
Closed

GRPC Instrumentation not adding rpc.body to spans #313

shashank11p opened this issue May 5, 2021 · 2 comments · Fixed by #322
Labels
area:instrumentation bug Something isn't working

Comments

@shashank11p
Copy link
Contributor

The GRPC instrumentation is not able to add rpc.request.body and rpc.response.body attributes to spans as the protobuf classes are shaded in the javaagent so the instrumentation looks for shaded classes, while during runtime the actual classes are used.

So we should not shade the protobuf dependencies in javaagent. But javaagent also needs to have protobuf dependency for config. So we need to have the protobuf in javaagent to be in agentClassLoader, and do not shade it so that GRPC instrumentation works.

@pavolloffay pavolloffay added bug Something isn't working area:instrumentation labels May 5, 2021
@pavolloffay
Copy link
Member

We should also include gRPC in our smoke tests and test the payload capture.

@pavolloffay
Copy link
Member

The best way to resolve this is to:

  1. remove shading of config dependencies (protobuf, fasterxml...)
  2. put the config dependencies into agent classloader
  3. create config interface that will be backed by the implementation in the agent classloader.
  4. load the config in the component installer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:instrumentation bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants