Skip to content

Commit 31576cf

Browse files
committed
nits
1 parent ccb682d commit 31576cf

File tree

3 files changed

+8
-24
lines changed

3 files changed

+8
-24
lines changed

kafka-streams-serdes/build.gradle.kts

-9
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
plugins {
22
`java-library`
33
jacoco
4-
id("com.google.protobuf") version "0.9.3"
54
id("org.hypertrace.avro-plugin")
65
id("org.hypertrace.publish-plugin")
76
id("org.hypertrace.jacoco-report-plugin")
@@ -25,11 +24,3 @@ dependencies {
2524
tasks.named<org.hypertrace.gradle.avro.CheckAvroCompatibility>("avroCompatibilityCheck") {
2625
enabled = false
2726
}
28-
29-
sourceSets {
30-
test {
31-
java {
32-
srcDirs("src/test/proto") // Generated Proto classes
33-
}
34-
}
35-
}
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,38 @@
11
package org.hypertrace.core.kafkastreams.framework.serdes;
22

3+
import com.google.protobuf.Value;
34
import org.apache.kafka.common.serialization.Deserializer;
45
import org.apache.kafka.common.serialization.Serializer;
56
import org.hypertrace.core.kafkastreams.framework.serdes.proto.ProtoDeserializer;
67
import org.hypertrace.core.kafkastreams.framework.serdes.proto.ProtoSerializer;
78
import org.junit.jupiter.api.Assertions;
89
import org.junit.jupiter.api.Test;
9-
import proto.TestProtoRecordOuterClass.TestProtoRecord;
1010

1111
public class ProtoSerdeTest {
1212

1313
private static final String TEST_TOPIC = "test-topic";
1414

1515
// Subclass for testing with proto deserialization
16-
public static class TestProtoRecordDeserializer extends ProtoDeserializer<TestProtoRecord> {
16+
public static class TestProtoRecordDeserializer extends ProtoDeserializer<Value> {
1717
public TestProtoRecordDeserializer() {
18-
super(TestProtoRecord.parser());
18+
super(Value.parser());
1919
}
2020
}
2121

2222
@Test
2323
public void testSerialize() {
24-
Serializer<TestProtoRecord> serializer = new ProtoSerializer<>();
24+
Serializer<Value> serializer = new ProtoSerializer<>();
2525

26-
Deserializer<TestProtoRecord> deserializer = new TestProtoRecordDeserializer();
27-
TestProtoRecord message = TestProtoRecord.newBuilder().setId("id").build();
26+
Deserializer<Value> deserializer = new TestProtoRecordDeserializer();
27+
Value message = Value.newBuilder().setStringValue("id").build();
2828

2929
byte[] serializedData = serializer.serialize(TEST_TOPIC, message);
3030

3131
Assertions.assertNotNull(serializedData);
3232
Assertions.assertTrue(serializedData.length > 0);
3333

34-
TestProtoRecord deserializedMessage = deserializer.deserialize(TEST_TOPIC, serializedData);
34+
Value deserializedMessage = deserializer.deserialize(TEST_TOPIC, serializedData);
3535

36-
Assertions.assertEquals(message.getId(), deserializedMessage.getId());
36+
Assertions.assertEquals(message.getStringValue(), deserializedMessage.getStringValue());
3737
}
3838
}

kafka-streams-serdes/src/test/proto/TestProtoRecord.proto

-7
This file was deleted.

0 commit comments

Comments
 (0)