Merge pull request #34 from hypervel/feature/replcae-laminas-mime

Feat: support PHP 8.4

Author: albertcht

.github/workflows/static-analysis.yml

@@ -17,6 +17,8 @@ jobs:
             swoole: "5.1.6"
           - php: "8.3"
             swoole: "5.1.6"
+          - php: "8.4"
+            swoole: "6.0.2"
 
     name: PHP ${{ matrix.php }} (swoole-${{ matrix.swoole }})
 

.github/workflows/tests.yml

@@ -17,6 +17,8 @@ jobs:
             swoole: "5.1.6"
           - php: "8.3"
             swoole: "5.1.6"
+          - php: "8.4"
+            swoole: "6.0.2"
 
     name: PHP ${{ matrix.php }} (swoole-${{ matrix.swoole }})
 

composer.json

@@ -122,7 +122,8 @@
         "tijsverkoyen/css-to-inline-styles": "^2.2.5",
         "symfony/process": "^6.2",
         "dragonmantank/cron-expression": "^3.3.2",
-        "friendsofhyperf/redis-subscriber": "~3.1.0"
+        "friendsofhyperf/redis-subscriber": "~3.1.0",
+        "hypervel/laminas-mime": "^0.1.0"
     },
     "replace": {
         "hypervel/auth": "self.version",
@@ -172,7 +173,7 @@
     },
     "require-dev": {
         "ably/ably-php": "^1.0",
-        "fakerphp/faker": "^2.0",
+        "fakerphp/faker": "^1.24.1",
         "filp/whoops": "^2.15",
         "friendsofphp/php-cs-fixer": "^3.57.2",
         "hyperf/devtool": "~3.1.0",
@@ -184,7 +185,7 @@
         "league/flysystem-google-cloud-storage": "^3.0",
         "league/flysystem-path-prefixing": "^3.3",
         "league/flysystem-read-only": "^3.3",
-        "mockery/mockery": "^1.5.1",
+        "mockery/mockery": "1.6.x-dev",
         "nunomaduro/collision": "^8.5",
         "pda/pheanstalk": "v5.0.9",
         "phpstan/phpstan": "^1.11.5",

src/cache/src/LimitedMaxHeap.php

@@ -12,18 +12,19 @@ public function __construct(protected int $limit)
     {
     }
 
-    public function insert(mixed $value): bool
+    public function insert(mixed $value): true
     {
         if ($this->count() < $this->limit) {
-            return parent::insert($value);
+            parent::insert($value);
+            return true;
         }
 
         if ($this->compare($value, $this->top()) < 0) {
             $this->extract();
-
-            return parent::insert($value);
         }
 
-        return false;
+        parent::insert($value);
+
+        return true;
     }
 }