Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing Esc twice closes the modal in Chrome #6

Closed
hyunbinseo opened this issue Nov 24, 2024 · 3 comments
Closed

Pressing Esc twice closes the modal in Chrome #6

hyunbinseo opened this issue Nov 24, 2024 · 3 comments

Comments

@hyunbinseo
Copy link
Owner

Reference https://issues.chromium.org/issues/351867704#comment8
@hyunbinseo
Copy link
Owner Author

The light-dismiss behavior from popover comes to <dialog>

One of the nice features of the Popover API is its light dismiss behavior. This behavior is now part of <dialog>, with a new closedby attribute controlling the behavior:

  • <dialog closedby="none">: No user-triggered closing of dialogs at all.

New in Chrome 134

@hyunbinseo
Copy link
Owner Author

Supported from [email protected]

@hyunbinseo
Copy link
Owner Author

Fixed by 70d5fd2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hyunbinseo