New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide transition presets with tree-shaking #7

Open

1 task

hyunbinseo opened this issue Jan 3, 2025 · 0 comments

Labels

Owner

hyunbinseo commented Jan 3, 2025 •

edited

Loading

As of v3.0.0, the fly transition is bundled into the modal component, regardless of being used.

Option 1: Prop-based Dynamic Import

Allow transition to be specified via prop
Load transition CSS dynamically when component mounts
FOUC is not a major concern since modals start hidden

Option 2: Separate Components (Recommended)

Create distinct components for each transition variant
Better tree-shaking as unused transitions won't be included

Examples

horizontal slide-in transition for off-canvas menu (sidebar)

hyunbinseo added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment