Skip to content

Commit 983c1a3

Browse files
committed
Refactor internal state, selectedIndex => selected
1 parent 632689e commit 983c1a3

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

lib/Input.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ class Input extends React.Component {
6565
}
6666

6767
render () {
68-
const { query, placeholder, expanded, listboxId, selectedIndex } = this.props
68+
const { query, placeholder, expanded, listboxId, selected } = this.props
6969

7070
return (
7171
<div className={this.props.classNames.searchInput}>
@@ -77,7 +77,7 @@ class Input extends React.Component {
7777
aria-autocomplete='list'
7878
aria-label={placeholder}
7979
aria-owns={listboxId}
80-
aria-activedescendant={selectedIndex > -1 ? `${listboxId}-${selectedIndex}` : null}
80+
aria-activedescendant={selected > -1 ? `${listboxId}-${selected}` : null}
8181
aria-expanded={expanded}
8282
style={{ width: this.state.inputWidth }} />
8383
<div ref={(c) => { this.sizer = c }} style={SIZER_STYLES}>{query || placeholder}</div>

lib/ReactTags.js

+13-13
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class ReactTags extends React.Component {
3535
query: '',
3636
focused: false,
3737
expanded: false,
38-
selectedIndex: -1,
38+
selected: -1,
3939
classNames: Object.assign({}, CLASS_NAMES, this.props.classNames)
4040
}
4141
}
@@ -57,12 +57,12 @@ class ReactTags extends React.Component {
5757
}
5858

5959
onKeyDown (e) {
60-
const { query, selectedIndex } = this.state
60+
const { query, selected } = this.state
6161
const { delimiters } = this.props
6262

6363
// when one of the terminating keys is pressed, add current query to the tags.
6464
if (delimiters.indexOf(e.key) > -1) {
65-
if (query || selectedIndex > -1) {
65+
if (query || selected > -1) {
6666
e.preventDefault()
6767
}
6868

@@ -72,7 +72,7 @@ class ReactTags extends React.Component {
7272
suggestion.name.search(new RegExp(`^${query}$`, 'i')) === 0
7373
))
7474

75-
const index = selectedIndex === -1 ? match : selectedIndex
75+
const index = selected === -1 ? match : selected
7676

7777
if (index > -1) {
7878
this.addTag(this.suggestions.state.options[index])
@@ -91,17 +91,17 @@ class ReactTags extends React.Component {
9191
e.preventDefault()
9292

9393
// if last item, cycle to the bottom
94-
if (selectedIndex <= 0) {
95-
this.setState({ selectedIndex: this.suggestions.state.options.length - 1 })
94+
if (selected <= 0) {
95+
this.setState({ selected: this.suggestions.state.options.length - 1 })
9696
} else {
97-
this.setState({ selectedIndex: selectedIndex - 1 })
97+
this.setState({ selected: selected - 1 })
9898
}
9999
}
100100

101101
if (e.key === KEYS.DOWN_ARROW) {
102102
e.preventDefault()
103103

104-
this.setState({ selectedIndex: (selectedIndex + 1) % this.suggestions.state.options.length })
104+
this.setState({ selected: (selected + 1) % this.suggestions.state.options.length })
105105
}
106106
}
107107

@@ -112,7 +112,7 @@ class ReactTags extends React.Component {
112112
}
113113

114114
onBlur () {
115-
this.setState({ focused: false, selectedIndex: -1 })
115+
this.setState({ focused: false, selected: -1 })
116116

117117
if (this.props.onBlur) {
118118
this.props.onBlur()
@@ -137,7 +137,7 @@ class ReactTags extends React.Component {
137137
// reset the state
138138
this.setState({
139139
query: '',
140-
selectedIndex: -1
140+
selected: -1
141141
})
142142
}
143143

@@ -171,10 +171,10 @@ class ReactTags extends React.Component {
171171
</div>
172172
<div
173173
className={this.state.classNames.search}
174-
onBlurCapture={this.onBlur.bind(this)}
175174
onFocusCapture={this.onFocus.bind(this)}
176-
onInput={this.onInput.bind(this)}
177-
onKeyDown={this.onKeyDown.bind(this)}>
175+
onBlurCapture={this.onBlur.bind(this)}
176+
onKeyDown={this.onKeyDown.bind(this)}
177+
onInput={this.onInput.bind(this)}>
178178
<Input {...this.state}
179179
ref={(c) => { this.input = c }}
180180
listboxId={listboxId}

lib/Suggestions.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class Suggestions extends React.Component {
4949
const key = `${this.props.listboxId}-${i}`
5050
const classNames = []
5151

52-
if (this.props.selectedIndex === i) {
52+
if (this.props.selected === i) {
5353
classNames.push(this.props.classNames.suggestionActive)
5454
}
5555

0 commit comments

Comments
 (0)