-
Notifications
You must be signed in to change notification settings - Fork 168
apparently keyCode is obsolete, and has been for a while #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for your query @Pomax. Hopefully this has not caused anybody any issues - these things do tend to unofficially converge with specced features... |
I suspect most browsers still support it because it would break all the things if they didn't, but probably worth updating for a next version =) The |
I tried switching from |
boo =( (thanks Edge team...) |
The If we use delimiterChars, then we could do something like:
But that has the risk of causing issues where we really want multi-character delimiters, if there really is a use-case for them. Whatever solution we come up with, we need to consider:
|
I think the separation of delimiter keys (IE. pressing tab or enter) and delimiter characters is OK, so long as it is documented clearly. Using |
Opened issue #94, based on an issue discovered on Android Chrome, which has an unfortunate impact, when it comes to KeyboardEvent.key and onKeyDown in general. |
I just read through https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode which highlights that
event.keyCode
is actually obsolete and has been replaced byevent.code
instead, with https://w3c.github.io/uievents/#idl-keyboardeventinit having this to say:It might be necessary to update the code to make use of
.code
instead, in order to keep up with the DOM spec.The text was updated successfully, but these errors were encountered: