-
-
Notifications
You must be signed in to change notification settings - Fork 29
Fresh 2 support #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ggodet-bar
wants to merge
5
commits into
i18next:master
Choose a base branch
from
ggodet-bar:fresh-2-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fresh 2 support #98
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f0b29ac
Adds a middleware plugin for Fresh 2.x
ggodet-bar 9841320
Adds documentation
ggodet-bar 21be518
fix: testing framework
ggodet-bar a285b69
Install dev dependencies prior to running deno tests
ggodet-bar cef7d6c
Improves passing of locale data and adds addRoute test
ggodet-bar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import { expect } from 'jsr:@std/expect' | ||
| import { assertEquals, assertNotEquals } from 'https://deno.land/std/testing/asserts.ts' | ||
| import i18next from 'https://deno.land/x/i18next/index.js' | ||
| import i18nextMiddleware from '../../index.js' | ||
| const { test } = Deno | ||
| import { App } from "jsr:@fresh/core"; | ||
|
|
||
| i18next | ||
| .use(i18nextMiddleware.LanguageDetector) | ||
| .init({ | ||
| preload: ["en", "fr"], | ||
| fallbackLng: "en", | ||
| resources: { | ||
| en: { | ||
| translation: { hi: "hello" } | ||
| }, | ||
| fr: { | ||
| translation: { hi: "bonjour" } | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| test('middleware fresh', async () => { | ||
| const handler = new App() | ||
| .use(i18nextMiddleware.freshPlugin(i18next)) | ||
| .get("/", (ctx) => { | ||
| return new Response(ctx.state.t('hi')) | ||
| }) | ||
| .handler(); | ||
|
|
||
| const headers = new Headers() | ||
| headers.append('Accept-Language', 'fr') | ||
| const res = await handler( | ||
| new Request('http://localhost', | ||
| { headers } | ||
| )); | ||
| const resHeaders = Object.fromEntries(res.headers.entries()) | ||
| expect(resHeaders).toEqual(expect.objectContaining({ 'content-language': 'fr'})) | ||
| expect(await res.text()).toEqual("bonjour") | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are all these new dependencies necessary?