Made error messages more readable

Author: iainbeeston

lib/json_validator.rb

@@ -37,6 +37,10 @@ def json(value)
   def translate_message(msg)
     # remove suffix
     msg.gsub!(/ in schema .*$/, '')
+    # lowercase first letter (eg. 'The' becomes 'the')
+    msg.gsub!(/^./) { |m| m.downcase }
+    # prefix with 'is invalid'
+    msg.gsub!(/^(.*)$/, 'is invalid (\1)')
   end
 
   def check_validity!

spec/lib/json_validator_spec.rb

@@ -52,7 +52,7 @@ def initialize(json_data)
           {}
         ).to(
           {
-            json_data: ["The property '#/' did not contain a required property of 'soup'"]
+            json_data: ["is invalid (the property '#/' did not contain a required property of 'soup')"]
           }
         )
       end
@@ -90,7 +90,7 @@ def initialize(json_data)
           {}
         ).to(
           {
-            json_data: ["The property '#/menu' was not of a minimum string length of 200"]
+            json_data: ["is invalid (the property '#/menu' was not of a minimum string length of 200)"]
           }
         )
       end
@@ -150,7 +150,7 @@ def initialize(json_data)
 
     it 'translates json-schema messages to slightly more readable ones' do
       msg = "The property '#/menu' was not of a minimum string length of 200 in schema 40148e2f-45d6-51b7-972a-179bd9de61d6#"
-      expect(subject.translate_message(msg)).to eq("The property '#/menu' was not of a minimum string length of 200")
+      expect(subject.translate_message(msg)).to eq("is invalid (the property '#/menu' was not of a minimum string length of 200)")
     end
   end