From 5efcf34c6378569ee0f2658570b11f241a81fbfc Mon Sep 17 00:00:00 2001 From: Riley Bruins Date: Sat, 6 May 2023 10:36:16 -0700 Subject: [PATCH 1/8] cache bufnr to prevent bugs --- autoload/mkdp/autocmd.vim | 9 +++++---- autoload/mkdp/rpc.vim | 8 ++++---- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/autoload/mkdp/autocmd.vim b/autoload/mkdp/autocmd.vim index 9f1aa77e..f86e4e30 100644 --- a/autoload/mkdp/autocmd.vim +++ b/autoload/mkdp/autocmd.vim @@ -1,6 +1,7 @@ " init preview key action function! mkdp#autocmd#init() abort - execute 'augroup MKDP_REFRESH_INIT' . bufnr('%') + let s:bufnum = bufnr('%') + execute 'augroup MKDP_REFRESH_INIT' . s:bufnum autocmd! " refresh autocmd if g:mkdp_refresh_slow @@ -10,13 +11,13 @@ function! mkdp#autocmd#init() abort endif " autoclose autocmd if g:mkdp_auto_close - autocmd BufHidden call mkdp#rpc#preview_close() + autocmd BufHidden call mkdp#rpc#preview_close(s:bufnum) endif " server close autocmd autocmd VimLeave * call mkdp#rpc#stop_server() augroup END endfunction -function! mkdp#autocmd#clear_buf() abort - execute 'autocmd! ' . 'MKDP_REFRESH_INIT' . bufnr('%') +function! mkdp#autocmd#clear_buf(bufnum) abort + execute 'autocmd! ' . 'MKDP_REFRESH_INIT' . a:bufnum endfunction diff --git a/autoload/mkdp/rpc.vim b/autoload/mkdp/rpc.vim index b257571a..20477940 100644 --- a/autoload/mkdp/rpc.vim +++ b/autoload/mkdp/rpc.vim @@ -109,18 +109,18 @@ function! mkdp#rpc#preview_refresh() abort endif endfunction -function! mkdp#rpc#preview_close() abort +function! mkdp#rpc#preview_close(bufnum) abort if s:is_vim if s:mkdp_channel_id !=# v:null - call mkdp#rpc#notify(s:mkdp_channel_id, 'close_page', { 'bufnr': bufnr('%') }) + call mkdp#rpc#notify(s:mkdp_channel_id, 'close_page', { 'bufnr': a:bufnum }) endif else if s:mkdp_channel_id !=# -1 - call rpcnotify(s:mkdp_channel_id, 'close_page', { 'bufnr': bufnr('%') }) + call rpcnotify(s:mkdp_channel_id, 'close_page', { 'bufnr': a:bufnum }) endif endif let b:MarkdownPreviewToggleBool = 0 - call mkdp#autocmd#clear_buf() + call mkdp#autocmd#clear_buf(a:bufnum) endfunction function! mkdp#rpc#open_browser() abort From c4cae8b35aedbec38657849c9e8988b1d958282c Mon Sep 17 00:00:00 2001 From: ribru17 Date: Mon, 15 May 2023 20:30:49 -0700 Subject: [PATCH 2/8] style: properly display header icons in dark mode, center mermaid diagrams --- app/_static/markdown.css | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/app/_static/markdown.css b/app/_static/markdown.css index e8fd08a8..eee5e9c5 100644 --- a/app/_static/markdown.css +++ b/app/_static/markdown.css @@ -309,3 +309,13 @@ box-sizing: border-box; padding: 0; } +.octicon { + fill: var(--color-text-primary); +} +.mermaid { + display: flex; + justify-content: center; +} +.mermaid > svg { + max-width: none !important; +} From 840659cfb0cb62c6ca8db320fa97e1f689b23875 Mon Sep 17 00:00:00 2001 From: Riley Bruins Date: Thu, 1 Jun 2023 08:41:10 -0700 Subject: [PATCH 3/8] fix: font looks bad on some devices, automatically defaulting to browser default monospace --- app/_static/markdown.css | 1 - 1 file changed, 1 deletion(-) diff --git a/app/_static/markdown.css b/app/_static/markdown.css index eee5e9c5..b16e45df 100644 --- a/app/_static/markdown.css +++ b/app/_static/markdown.css @@ -253,7 +253,6 @@ content: normal; } .markdown-body code { - font-family: Consolas, "Liberation Mono", Menlo, Courier, monospace; padding: 0; padding-top: 0.2em; padding-bottom: 0.2em; From 226ce0185636984168d60fdf75f574d3d1f78cf8 Mon Sep 17 00:00:00 2001 From: Riley Bruins Date: Tue, 6 Jun 2023 16:25:42 -0700 Subject: [PATCH 4/8] feat: centered viz.js diagrams --- app/_static/markdown.css | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/_static/markdown.css b/app/_static/markdown.css index b16e45df..267daf2d 100644 --- a/app/_static/markdown.css +++ b/app/_static/markdown.css @@ -318,3 +318,8 @@ .mermaid > svg { max-width: none !important; } +.dot { + display: flex; + justify-content: center; + align-items: center; +} From e873a823c118316791e13a9cff925fc5651c1953 Mon Sep 17 00:00:00 2001 From: Riley Bruins Date: Sat, 29 Jul 2023 20:26:42 -0700 Subject: [PATCH 5/8] feat: improve diff highlighting in dark mode --- app/_static/highlight.css | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/_static/highlight.css b/app/_static/highlight.css index a8a85cf8..1f45d7a4 100644 --- a/app/_static/highlight.css +++ b/app/_static/highlight.css @@ -5,9 +5,13 @@ github.com style (c) Vasily Polovnyov */ :root { --color-text-primary: #333; + --color-diff-add: #dfd; + --color-diff-remove: #fdd; } [data-theme="dark"] { --color-text-primary: #c9d1d9; + --color-diff-add: #484; + --color-diff-remove: #844; } .hljs { @@ -89,11 +93,11 @@ github.com style (c) Vasily Polovnyov } .hljs-deletion { - background: #fdd; + background: var(--color-diff-remove); } .hljs-addition { - background: #dfd; + background: var(--color-diff-add); } .hljs-emphasis { From 2d6fbb59197db23489a6ffddc8d269ee581938b8 Mon Sep 17 00:00:00 2001 From: Riley Bruins Date: Wed, 13 Sep 2023 14:30:30 -0700 Subject: [PATCH 6/8] feat: better checkbox differentiation --- app/_static/markdown.css | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/_static/markdown.css b/app/_static/markdown.css index 267daf2d..48c82c4a 100644 --- a/app/_static/markdown.css +++ b/app/_static/markdown.css @@ -302,6 +302,9 @@ box-sizing: border-box; padding: 0; } +.task-list-item input[type="checkbox"]:checked { + filter: invert() brightness(2.5) invert(); +} .task-list-item input[type="radio"] { -webkit-box-sizing: border-box; -moz-box-sizing: border-box; From f55c5e84c6f709c1d6a55a04ef64745dc044c486 Mon Sep 17 00:00:00 2001 From: Riley Bruins Date: Fri, 29 Sep 2023 16:50:23 -0700 Subject: [PATCH 7/8] feat: use most up to date version of mermaid --- app/pages/index.jsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/pages/index.jsx b/app/pages/index.jsx index ee12b646..f87014d4 100644 --- a/app/pages/index.jsx +++ b/app/pages/index.jsx @@ -317,7 +317,9 @@ export default class PreviewPage extends React.Component { - + From 3e8eb8f9d7587ed807e0ac7af420d657d2ccfea0 Mon Sep 17 00:00:00 2001 From: Riley Bruins Date: Fri, 29 Sep 2023 16:57:58 -0700 Subject: [PATCH 8/8] revert: undoing mermaid changes --- app/pages/index.jsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/pages/index.jsx b/app/pages/index.jsx index f87014d4..ee12b646 100644 --- a/app/pages/index.jsx +++ b/app/pages/index.jsx @@ -317,9 +317,7 @@ export default class PreviewPage extends React.Component { - +