Prepare to use tslint (#23)

* Prepare to use tslint

* add newline character

* Require tslint as a dev dependency

* Add `fix` command

* Make automatic fixes by tslint

Author: przepompownia

package.json

@@ -17,7 +17,9 @@
     "build-docs": "rm ./src/docs/builtin-docs.json && ./bin/build-docs.js",
     "build": "rm -rf ./out && webpack",
     "watch": "webpack -w",
-    "test": "mocha test/src/**/*.ts --require ts-node/register"
+    "test": "mocha test/src/**/*.ts --require ts-node/register",
+    "lint": "tslint -c tslint.json {.,test}/src/**/*.ts",
+    "fix": "tslint -c tslint.json --fix {.,test}/src/**/*.ts"
   },
   "bin": {
     "vim-language-server": "./bin/index.js"
@@ -39,6 +41,7 @@
     "vscode-languageserver": "^5.2.1",
     "vscode-uri": "^1.0.6",
     "webpack": "^4.41.2",
-    "webpack-cli": "^3.3.9"
+    "webpack-cli": "^3.3.9",
+    "tslint": "^5.20.0"
   }
 }

src/common/constant.ts

@@ -1,8 +1,8 @@
 export const sortTexts = {
-  one: '00001',
-  two: '00002',
-  three: '00003',
-  four: '00004'
-}
+  one: "00001",
+  two: "00002",
+  three: "00003",
+  four: "00004",
+};
 
-export const projectRootPatterns = ['.git', 'autoload', 'plugin']
+export const projectRootPatterns = [".git", "autoload", "plugin"];

src/common/fuzzy.ts

@@ -16,4 +16,4 @@ export default function fuzzy(origin: string, query: string): number {
   }
 
   return score;
-};
+}

src/common/logger.ts

@@ -1,18 +1,18 @@
-import { connection } from '../server/connection';
+import { connection } from "../server/connection";
 
 export default function(name: string) {
   return {
     log(message: string) {
-      connection.console.log(`${name}: ${message}`)
+      connection.console.log(`${name}: ${message}`);
     },
     info(message: string) {
-      connection.console.info(`${name}: ${message}`)
+      connection.console.info(`${name}: ${message}`);
     },
     warn(message: string) {
-      connection.console.warn(`${name}: ${message}`)
+      connection.console.warn(`${name}: ${message}`);
     },
     error(message: string) {
-      connection.console.error(`${name}: ${message}`)
+      connection.console.error(`${name}: ${message}`);
     },
-  }
+  };
 }

src/common/patterns.ts

@@ -1,37 +1,37 @@
-export type kindPattern = RegExp[]
+export type kindPattern = RegExp[];
 
-export const errorLinePattern = /[^:]+:\s*(.+?):\s*line\s*([0-9]+)\s*col\s*([0-9]+)/
+export const errorLinePattern = /[^:]+:\s*(.+?):\s*line\s*([0-9]+)\s*col\s*([0-9]+)/;
 
-export const commentPattern = /^[ \t]*("|')/
+export const commentPattern = /^[ \t]*("|')/;
 
-export const keywordPattern = /[\w#&$<>.:]/
+export const keywordPattern = /[\w#&$<>.:]/;
 
-export const builtinFunctionPattern = /^((<SID>|\b(v|g|b|s|l|a):)?[\w#&]+)[ \t]*\([^)]*\)/
+export const builtinFunctionPattern = /^((<SID>|\b(v|g|b|s|l|a):)?[\w#&]+)[ \t]*\([^)]*\)/;
 
-export const wordPrePattern = /^.*?(((<SID>|\b(v|g|b|s|l|a):)?[\w#&$.]+)|(<SID>|<SID|<SI|<S|<|\b(v|g|b|s|l|a):))$/
+export const wordPrePattern = /^.*?(((<SID>|\b(v|g|b|s|l|a):)?[\w#&$.]+)|(<SID>|<SID|<SI|<S|<|\b(v|g|b|s|l|a):))$/;
 
-export const wordNextPattern = /^((SID>|ID>|D>|>|<SID>|\b(v|g|b|s|l|a):)?[\w#&$.]+|(:[\w#&$.]+)).*?(\r\n|\r|\n)?$/
+export const wordNextPattern = /^((SID>|ID>|D>|>|<SID>|\b(v|g|b|s|l|a):)?[\w#&$.]+|(:[\w#&$.]+)).*?(\r\n|\r|\n)?$/;
 
-export const colorschemePattern = /\bcolorscheme[ \t]+\w*$/
+export const colorschemePattern = /\bcolorscheme[ \t]+\w*$/;
 
-export const mapCommandPattern = /^([ \t]*(\[ \t]*)?)\w*map[ \t]+/
+export const mapCommandPattern = /^([ \t]*(\[ \t]*)?)\w*map[ \t]+/;
 
-export const highlightLinkPattern = /^[ \t]*(hi|highlight)[ \t]+link([ \t]+[^ \t]+)*[ \t]*$/
+export const highlightLinkPattern = /^[ \t]*(hi|highlight)[ \t]+link([ \t]+[^ \t]+)*[ \t]*$/;
 
-export const highlightPattern = /^[ \t]*(hi|highlight)([ \t]+[^ \t]+)*[ \t]*$/
+export const highlightPattern = /^[ \t]*(hi|highlight)([ \t]+[^ \t]+)*[ \t]*$/;
 
-export const highlightValuePattern = /^[ \t]*(hi|highlight)([ \t]+[^ \t]+)*[ \t]+([^ \t=]+)=[^ \t=]*$/
+export const highlightValuePattern = /^[ \t]*(hi|highlight)([ \t]+[^ \t]+)*[ \t]+([^ \t=]+)=[^ \t=]*$/;
 
-export const autocmdPattern = /^[ \t]*(au|autocmd)!?[ \t]+([^ \t,]+,)*[^ \t,]*$/
+export const autocmdPattern = /^[ \t]*(au|autocmd)!?[ \t]+([^ \t,]+,)*[^ \t,]*$/;
 
 export const builtinVariablePattern = [
-  /\bv:\w*$/
-]
+  /\bv:\w*$/,
+];
 
 export const optionPattern = [
   /(^|[ \t]+)&\w*$/,
-  /(^|[ \t]+)set(l|local|g|global)?[ \t]+\w+$/
-]
+  /(^|[ \t]+)set(l|local|g|global)?[ \t]+\w+$/,
+];
 
 export const notFunctionPattern = [
   /^[ \t]*\\$/,
@@ -40,28 +40,28 @@ export const notFunctionPattern = [
   /(let|set|colorscheme)[ \t][^ \t]*$/,
   /[^([,\\ \t\w#]\w*$/,
   /^[ \t]*(hi|highlight)([ \t]+link)?([ \t]+[^ \t]+)*[ \t]*$/,
-  autocmdPattern
-]
+  autocmdPattern,
+];
 
 export const commandPattern = [
   /(^|[ \t]):\w+$/,
   /^[ \t]*\w+$/,
-  /:?silent!?[ \t]\w+/
-]
+  /:?silent!?[ \t]\w+/,
+];
 
 export const featurePattern = [
-  /\bhas\([ \t]*["']\w*/
-]
+  /\bhas\([ \t]*["']\w*/,
+];
 
 export const expandPattern = [
   /\bexpand\(['"]<\w*$/,
-  /\bexpand\([ \t]*['"]\w*$/
-]
+  /\bexpand\([ \t]*['"]\w*$/,
+];
 
 export const notIdentifierPattern = [
   commentPattern,
   /("|'):\w*$/,
   /^[ \t]*\\$/,
   /^[ \t]*call[ \t]+[^ \t()]*$/,
-  /('|"|#|&|\$|<)\w*$/
-]
+  /('|"|#|&|\$|<)\w*$/,
+];

src/common/types.ts

@@ -1,35 +1,35 @@
-import { Subscription} from 'rxjs';
-import { CompletionItem } from 'vscode-languageserver';
+import { Subscription} from "rxjs";
+import { CompletionItem } from "vscode-languageserver";
 
 export interface IParserHandles {
-  [uri: string]: Subscription | undefined
+  [uri: string]: Subscription | undefined;
 }
 
 export interface IDiagnostic {
-  enable: boolean
+  enable: boolean;
 }
 
 export interface ISuggest {
-  fromRuntimepath: boolean
-  fromVimruntime: boolean
+  fromRuntimepath: boolean;
+  fromVimruntime: boolean;
 }
 
 export interface IIndexes {
-  runtimepath: boolean
-  gap: number
-  count: number,
-  projectRootPatterns: string[]
+  runtimepath: boolean;
+  gap: number;
+  count: number;
+  projectRootPatterns: string[];
 }
 
 // initialization options
 export interface IConfig {
-  iskeyword: string
-  vimruntime: string
-  runtimepath: string[]
-  diagnostic: IDiagnostic
-  snippetSupport: boolean
-  suggest: ISuggest
-  indexes: IIndexes
+  iskeyword: string;
+  vimruntime: string;
+  runtimepath: string[];
+  diagnostic: IDiagnostic;
+  snippetSupport: boolean;
+  suggest: ISuggest;
+  indexes: IIndexes;
 }
 
 // builtin-doc
@@ -41,15 +41,15 @@ export interface BuiltinDoc {
     variables: CompletionItem[]
     features: CompletionItem[]
     expandKeywords: CompletionItem[]
-    autocmds: CompletionItem[]
-  }
-  signatureHelp: Record<string, string[]>
+    autocmds: CompletionItem[],
+  };
+  signatureHelp: Record<string, string[]>;
   documents: {
     functions: Record<string, string[]>
     commands: Record<string, string[]>
     options: Record<string, string[]>
     variables: Record<string, string[]>
     features: Record<string, string[]>
-    expandKeywords: Record<string, string[]>
-  }
+    expandKeywords: Record<string, string[]>,
+  };
 }