Skip to content

Commit 164e6dc

Browse files
author
farhadzand
committed
refactor: change properties in RetentionConfig and RetentionResult to readonly
- Updated properties in `RetentionConfig` and `RetentionResult` classes to be readonly, ensuring immutability after object construction. - This change enhances data integrity and aligns with best practices for DTOs.
1 parent 56f3aba commit 164e6dc

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

src/DTOs/RetentionConfig.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@
44

55
namespace iamfarhad\LaravelAuditLog\DTOs;
66

7-
final readonly class RetentionConfig
7+
final class RetentionConfig
88
{
99
public function __construct(
10-
public bool $enabled,
11-
public int $days,
12-
public string $strategy,
13-
public int $batchSize,
14-
public int $anonymizeAfterDays,
15-
public ?string $archiveConnection,
16-
public string $entityType,
17-
public string $tableName,
10+
public readonly bool $enabled,
11+
public readonly int $days,
12+
public readonly string $strategy,
13+
public readonly int $batchSize,
14+
public readonly int $anonymizeAfterDays,
15+
public readonly ?string $archiveConnection,
16+
public readonly string $entityType,
17+
public readonly string $tableName,
1818
) {}
1919

2020
public static function fromArray(array $config, string $entityType, string $tableName): self

src/DTOs/RetentionResult.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,17 @@
44

55
namespace iamfarhad\LaravelAuditLog\DTOs;
66

7-
final readonly class RetentionResult
7+
final class RetentionResult
88
{
99
/**
1010
* @param array<string, int> $entitiesProcessed Array of entity => count processed
1111
* @param array<string> $errors Array of error messages
1212
*/
1313
public function __construct(
14-
public int $totalProcessed,
15-
public array $entitiesProcessed,
16-
public array $errors,
17-
public float $executionTime,
14+
public readonly int $totalProcessed,
15+
public readonly array $entitiesProcessed,
16+
public readonly array $errors,
17+
public readonly float $executionTime,
1818
) {}
1919

2020
public static function empty(): self

0 commit comments

Comments
 (0)