Update MySQLDriver.php #1
Conversation
fixes default connection for audit
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @azgooon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue where the MySQL audit logger driver might not have been using the correct database connection. I've added explicit connection calls to ensure all database operations within the driver target the connection configured in audit-logger.default, providing a fix for the default connection usage.
Highlights
- Database Connection: I've updated the MySQL driver to explicitly use the database connection specified by the
audit-logger.defaultconfiguration setting for all database interactions. - Consistency: This change ensures that storing single logs, storing batch logs, creating tables, and checking for table existence all consistently target the configured audit database connection.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly updates the MySQLDriver to use the configured default audit connection for all database interactions (storing logs, creating tables, checking table existence). The changes are consistent across the relevant methods. Feedback is provided regarding using the cached configuration value within the class for improved consistency and minor efficiency.
|
|
||
| try { | ||
| $model = EloquentAuditLog::forEntity(entityClass: $log->getEntityType()); | ||
| $model->setConnection(config('audit-logger.default')); |
There was a problem hiding this comment.
Consider using the cached configuration value $this->config['default'] instead of calling config() directly here. The configuration is already loaded and cached in the constructor for consistency and minor performance benefit.
$model->setConnection($this->config['default']);| // Use Eloquent models to leverage automatic JSON casting | ||
| foreach ($entityLogs as $log) { | ||
| $model = EloquentAuditLog::forEntity(entityClass: $entityType); | ||
| $model->setConnection(config('audit-logger.default')); |
There was a problem hiding this comment.
Similar to the store method, using the cached configuration value $this->config['default'] is preferred over calling config() directly.
$model->setConnection($this->config['default']);| $tableName = $this->getTableName($entityClass); | ||
|
|
||
| Schema::create($tableName, function (Blueprint $table) { | ||
| Schema::connection(config('audit-logger.default'))->create($tableName, function (Blueprint $table) { |
There was a problem hiding this comment.
Use the cached configuration value $this->config['default'] for the database connection when creating the schema.
Schema::connection($this->config['default'])->create($tableName, function (Blueprint $table) {|
|
||
| // Check database and cache the result | ||
| $exists = Schema::hasTable($tableName); | ||
| $exists = Schema::connection(config('audit-logger.default'))->hasTable($tableName); |
There was a problem hiding this comment.
Use the cached configuration value $this->config['default'] for the database connection when checking if the table exists.
$exists = Schema::connection($this->config['default'])->hasTable($tableName);
|
@azgooon check tests |
2 participants
fixes default connection for audit