fixup! Added tests for IBX-3035 - Fixed Sonar warning about duplicated code

Author: vidarl

tests/lib/MVC/Symfony/Templating/BaseRenderStrategyTest.php

@@ -24,7 +24,7 @@
 
 abstract class BaseRenderStrategyTest extends TestCase
 {
-    public function createRenderStrategy(
+    public static function createRenderStrategy(
         string $typeClass,
         array $fragmentRenderers,
         string $defaultMethod = 'inline',

tests/lib/MVC/Symfony/Templating/RenderContentStrategyTest.php

@@ -14,6 +14,7 @@
 use Ibexa\Core\MVC\Symfony\SiteAccess;
 use Ibexa\Core\MVC\Symfony\Templating\RenderContentStrategy;
 use Ibexa\Core\MVC\Symfony\Templating\RenderOptions;
+use PHPUnit\Framework\MockObject\MockObject;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Controller\ControllerReference;
@@ -94,40 +95,48 @@ public function testMultipleFragmentRenderers(): void
     }
 
     public function testForwardOptionsToFragmentRenderer(): void
+    {
+        static::forwardOptionsToFragmentRenderer(
+            $this->createMock(FragmentRendererInterface::class),
+            $this->createMock(Content::class),
+            RenderContentStrategy::class,
+        );
+    }
+
+    public static function forwardOptionsToFragmentRenderer(MockObject $fragmentRendererMock, MockObject $valueObjectMock, string $renderStrategyClass): void
     {
         $params = [
             'param1' => 'value1',
             'param2' => 'value2',
         ];
 
-        $fragmentRendererMock = $this->createMock(FragmentRendererInterface::class);
         $fragmentRendererMock
             ->method('getName')
             ->willReturn('fragment_render_mock');
-        $fragmentRendererMock->expects($this->once())
+        $fragmentRendererMock->expects(self::once())
             ->method('render')
             ->with(
-                $this->anything(),
-                $this->anything(),
-                $this->equalTo([
+                self::anything(),
+                self::anything(),
+                self::equalTo([
                     'params' => $params,
                 ])
             )
             ->willReturn(new Response('fragment_render_mock_rendered'));
 
-        $renderContentStrategy = $this->createRenderStrategy(
-            RenderContentStrategy::class,
+        $renderContentStrategy = static::createRenderStrategy(
+            $renderStrategyClass,
             [
                 $fragmentRendererMock,
             ],
         );
 
-        $contentMock = $this->createMock(Content::class);
-        $this->assertTrue($renderContentStrategy->supports($contentMock));
+        /** @var \Ibexa\Contracts\Core\Repository\Values\ValueObject&\PHPUnit\Framework\MockObject\MockObject $valueObjectMock */
+        self::assertTrue($renderContentStrategy->supports($valueObjectMock));
 
-        $this->assertSame(
+        self::assertSame(
             'fragment_render_mock_rendered',
-            $renderContentStrategy->render($contentMock, new RenderOptions([
+            $renderContentStrategy->render($valueObjectMock, new RenderOptions([
                 'method' => 'fragment_render_mock',
                 'viewType' => 'awesome',
                 'params' => [

tests/lib/MVC/Symfony/Templating/RenderLocationStrategyTest.php

@@ -9,11 +9,9 @@
 namespace Ibexa\Tests\Core\MVC\Symfony\Templating;
 
 use Ibexa\Contracts\Core\Repository\Exceptions\InvalidArgumentException;
-use Ibexa\Contracts\Core\Repository\Values\Content\Content;
 use Ibexa\Contracts\Core\Repository\Values\Content\Location;
 use Ibexa\Contracts\Core\Repository\Values\ValueObject;
 use Ibexa\Core\MVC\Symfony\SiteAccess;
-use Ibexa\Core\MVC\Symfony\Templating\RenderContentStrategy;
 use Ibexa\Core\MVC\Symfony\Templating\RenderLocationStrategy;
 use Ibexa\Core\MVC\Symfony\Templating\RenderOptions;
 use Symfony\Component\HttpFoundation\Request;
@@ -97,46 +95,10 @@ public function testMultipleFragmentRenderers(): void
 
     public function testForwardOptionsToFragmentRenderer(): void
     {
-        $params = [
-            'param1' => 'value1',
-            'param2' => 'value2',
-        ];
-
-        $fragmentRendererMock = $this->createMock(FragmentRendererInterface::class);
-        $fragmentRendererMock
-            ->method('getName')
-            ->willReturn('fragment_render_mock');
-        $fragmentRendererMock->expects($this->once())
-            ->method('render')
-            ->with(
-                $this->anything(),
-                $this->anything(),
-                $this->equalTo([
-                    'params' => $params,
-                ])
-            )
-            ->willReturn(new Response('fragment_render_mock_rendered'));
-
-        $renderContentStrategy = $this->createRenderStrategy(
-            RenderContentStrategy::class,
-            [
-                $fragmentRendererMock,
-            ],
-        );
-
-        $contentMock = $this->createMock(Content::class);
-        $this->assertTrue($renderContentStrategy->supports($contentMock));
-
-        $this->assertSame(
-            'fragment_render_mock_rendered',
-            $renderContentStrategy->render($contentMock, new RenderOptions([
-                'method' => 'fragment_render_mock',
-                'viewType' => 'awesome',
-                'params' => [
-                    'param1' => 'value1',
-                    'param2' => 'value2',
-                ],
-            ]))
+        RenderContentStrategyTest::forwardOptionsToFragmentRenderer(
+            $this->createMock(FragmentRendererInterface::class),
+            $this->createMock(Location::class),
+            RenderLocationStrategy::class,
         );
     }