Skip to content

Commit 1bb7be8

Browse files
committed
fixup! Changed $this->assert* to self::assert* in related tests - Adjusted PHPstand baseline
1 parent 233fa35 commit 1bb7be8

File tree

3 files changed

+0
-17
lines changed

3 files changed

+0
-17
lines changed

phpstan-baseline.neon

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -30570,12 +30570,6 @@ parameters:
3057030570
count: 1
3057130571
path: tests/bundle/Core/Fragment/DirectFragmentRendererTest.php
3057230572

30573-
-
30574-
message: '#^Call to method PHPUnit\\Framework\\Assert\:\:assertInstanceOf\(\) with ''Symfony\\\\Component\\\\HttpFoundation\\\\Response'' and Symfony\\Component\\HttpFoundation\\Response will always evaluate to true\.$#'
30575-
identifier: method.alreadyNarrowedType
30576-
count: 4
30577-
path: tests/bundle/Core/Fragment/DirectFragmentRendererTest.php
30578-
3057930573
-
3058030574
message: '#^Method Ibexa\\Tests\\Bundle\\Core\\Fragment\\FragmentListenerFactoryTest\:\:buildFragmentListenerProvider\(\) has no return type specified\.$#'
3058130575
identifier: missingType.return
@@ -58764,12 +58758,6 @@ parameters:
5876458758
count: 1
5876558759
path: tests/lib/MVC/Symfony/Templating/RenderContentStrategyTest.php
5876658760

58767-
-
58768-
message: '#^Call to method PHPUnit\\Framework\\Assert\:\:assertInstanceOf\(\) with ''Symfony\\\\Component\\\\HttpKernel\\\\Controller\\\\ControllerReference'' and Symfony\\Component\\HttpKernel\\Controller\\ControllerReference will always evaluate to true\.$#'
58769-
identifier: method.alreadyNarrowedType
58770-
count: 1
58771-
path: tests/lib/MVC/Symfony/Templating/RenderContentStrategyTest.php
58772-
5877358761
-
5877458762
message: '#^Anonymous function has an unused use \$content\.$#'
5877558763
identifier: closure.unusedUse

tests/bundle/Core/Fragment/DirectFragmentRendererTest.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ public function testSubRequestBuilding(): void
6565
$directFragmentRenderer = $this->getDirectFragmentRenderer($controllerResolver);
6666
$response = $directFragmentRenderer->render($controllerReference, $request);
6767

68-
self::assertInstanceOf(Response::class, $response);
6968
self::assertSame('rendered_response', $response->getContent());
7069
}
7170

@@ -82,7 +81,6 @@ public function testControllerResponse(): void
8281
$directFragmentRenderer = $this->getDirectFragmentRenderer($controllerResolver);
8382
$response = $directFragmentRenderer->render('', new Request(), []);
8483

85-
self::assertInstanceOf(Response::class, $response);
8684
self::assertSame('response_body', $response->getContent());
8785
}
8886

@@ -148,7 +146,6 @@ static function (ContentView $cV) use ($params): string {
148146
]
149147
);
150148

151-
self::assertInstanceOf(Response::class, $response);
152149
self::assertSame('rendered_template_identifier', $response->getContent());
153150
}
154151

@@ -165,7 +162,6 @@ public function testControllerStringResponse(): void
165162
$directFragmentRenderer = $this->getDirectFragmentRenderer($controllerResolver);
166163
$response = $directFragmentRenderer->render('', new Request(), []);
167164

168-
self::assertInstanceOf(Response::class, $response);
169165
self::assertSame('some_prerendered_response', $response->getContent());
170166
}
171167

tests/lib/MVC/Symfony/Templating/RenderContentStrategyTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,6 @@ public function testExpectedMethodRenderArgumentsFormat(): void
182182
->willReturn('method_b');
183183

184184
$controllerReferenceCallback = $this->callback(static function (ControllerReference $controllerReference) {
185-
self::assertInstanceOf(ControllerReference::class, $controllerReference);
186185
self::assertEquals('ibexa_content::viewAction', $controllerReference->controller);
187186
self::assertSame([
188187
'contentId' => 123,

0 commit comments

Comments
 (0)