IBX-9262: Fixed Relation::Asset not being cleaned up on content deletion (#523)

For more details see https://issues.ibexa.co/browse/IBX-9262 and #523

Key changes:

* Fixed Relation::Asset not being cleaned up on content deletion

---------

Co-Authored-By: Paweł Niedzielski <[email protected]>

Author: ViniTou

src/lib/Persistence/Legacy/Content/Gateway/DoctrineDatabase.php

@@ -1186,7 +1186,7 @@ public function removeReverseFieldRelations(int $contentId): void
                 )
             )
             ->setParameter('content_id', $contentId, ParameterType::INTEGER)
-            ->setParameter('relation_type', Relation::FIELD, ParameterType::INTEGER);
+            ->setParameter('relation_type', Relation::FIELD | Relation::ASSET, ParameterType::INTEGER);
 
         $statement = $query->execute();
 
@@ -1198,6 +1198,10 @@ public function removeReverseFieldRelations(int $contentId): void
             if ($row['data_type_string'] === 'ezobjectrelationlist') {
                 $this->removeRelationFromRelationListField($contentId, $row);
             }
+
+            if ($row['data_type_string'] === 'ezimageasset') {
+                $this->removeRelationFromAssetField($row);
+            }
         }
     }
 
@@ -1266,6 +1270,33 @@ private function removeRelationFromRelationField(array $row): void
         $query->execute();
     }
 
+    /**
+     * @param array{
+     *     id: int|string,
+     *     version: int|string,
+     *     data_type_string: string,
+     *     data_text: string|null
+     * } $row
+     */
+    private function removeRelationFromAssetField(array $row): void
+    {
+        $query = $this->connection->createQueryBuilder();
+        $query
+            ->update(self::CONTENT_FIELD_TABLE)
+            ->set('data_text', ':data_text')
+            ->set('data_int', ':data_int')
+            ->set('sort_key_int', ':sort_key_int')
+            ->setParameter('data_text', null, ParameterType::NULL)
+            ->setParameter('data_int', null, ParameterType::NULL)
+            ->setParameter('sort_key_int', 0, ParameterType::INTEGER)
+            ->andWhere('id = :attribute_id')
+            ->andWhere('version = :version_no')
+            ->setParameter('attribute_id', (int)$row['id'], ParameterType::INTEGER)
+            ->setParameter('version_no', (int)$row['version'], ParameterType::INTEGER);
+
+        $query->execute();
+    }
+
     public function deleteField(int $fieldId): void
     {
         $query = $this->connection->createQueryBuilder();

tests/integration/Core/Repository/ContentService/ImageAssetTest.php

@@ -0,0 +1,99 @@
+<?php
+
+/**
+ * @copyright Copyright (C) Ibexa AS. All rights reserved.
+ * @license For full copyright and license information view LICENSE file distributed with this source code.
+ */
+declare(strict_types=1);
+
+namespace Ibexa\Tests\Integration\Core\Repository\ContentService;
+
+use Ibexa\Contracts\Core\Repository\ContentService;
+use Ibexa\Contracts\Core\Repository\ContentTypeService;
+use Ibexa\Contracts\Core\Repository\Values\Content\Content;
+use Ibexa\Contracts\Core\Repository\Values\ContentType\ContentType;
+use Ibexa\Core\FieldType\Image\Value;
+use Ibexa\Core\FieldType\ImageAsset\Value as AssetValue;
+use Ibexa\Tests\Integration\Core\RepositoryTestCase;
+
+final class ImageAssetTest extends RepositoryTestCase
+{
+    private ContentService $contentService;
+
+    private ContentTypeService $contentTypeService;
+
+    protected function setUp(): void
+    {
+        parent::setUp();
+
+        $this->contentService = self::getContentService();
+        $this->contentTypeService = self::getContentTypeService();
+    }
+
+    public function testAssetRelationIsRemoved(): void
+    {
+        $contentType = $this->createContentTypeWithImageAsset();
+        $destinationContent = $this->createImageContent();
+
+        $struct = $this->contentService->newContentCreateStruct($contentType, 'eng-US');
+        $struct->setField('asset', new AssetValue(
+            $destinationContent->getId(),
+        ));
+        $assetContent = $this->contentService->publishVersion(
+            $this->contentService->createContent($struct)->getVersionInfo()
+        );
+
+        self::assertEquals(1, $this->contentService->countRelations($assetContent->getVersionInfo()));
+        self::assertEquals(1, $this->contentService->countReverseRelations($destinationContent->getContentInfo()));
+
+        $this->contentService->deleteContent($destinationContent->getContentInfo());
+
+        self::assertEquals(0, $this->contentService->countRelations($assetContent->getVersionInfo()));
+        self::assertEquals(0, $this->contentService->countReverseRelations($destinationContent->getContentInfo()));
+
+        $assetContent = $this->contentService->loadContentByContentInfo($assetContent->getContentInfo());
+
+        $value = $assetContent->getFieldValue('asset');
+        self::assertInstanceOf(AssetValue::class, $value);
+        self::assertNull($value->destinationContentId);
+    }
+
+    private function createContentTypeWithImageAsset(): ContentType
+    {
+        $struct = $this->contentTypeService->newContentTypeCreateStruct('content_type_with_image_asset');
+        $struct->names = ['eng-US' => 'Content Type with Image Asset'];
+
+        $struct->addFieldDefinition(
+            $this->contentTypeService->newFieldDefinitionCreateStruct('asset', 'ezimageasset')
+        );
+        $struct->mainLanguageCode = 'eng-US';
+        $contentType = $this->contentTypeService->createContentType(
+            $struct,
+            [$this->contentTypeService->loadContentTypeGroupByIdentifier('Content')],
+        );
+        $this->contentTypeService->publishContentTypeDraft($contentType);
+
+        return $this->contentTypeService->loadContentType($contentType->id);
+    }
+
+    private function createImageContent(): Content
+    {
+        $path = __DIR__ . '/../_fixtures/image/square.png';
+
+        $imageContentType = $this->contentTypeService->loadContentTypeByIdentifier('image');
+        $struct = $this->contentService->newContentCreateStruct($imageContentType, 'eng-US');
+        $struct->setField('name', 'Image Name');
+        $struct->setField('image', new Value(
+            [
+                'fileName' => 'square.jpg',
+                'inputUri' => $path,
+                'fileSize' => filesize($path),
+            ],
+        ));
+        $content = $this->contentService->createContent(
+            $struct
+        );
+
+        return $this->contentService->publishVersion($content->getVersionInfo());
+    }
+}