From 6dc6c499450e32039eec2646cb4e1df017495b77 Mon Sep 17 00:00:00 2001 From: Nathan Lynch Date: Wed, 24 Jul 2024 14:11:10 -0500 Subject: [PATCH 1/3] Add .editorconfig librtas basically follows Linux kernel coding style. Copy the relevant .editorconfig directives from that project. https://editorconfig.org/ Signed-off-by: Nathan Lynch --- .editorconfig | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 .editorconfig diff --git a/.editorconfig b/.editorconfig new file mode 100644 index 0000000..3493bcf --- /dev/null +++ b/.editorconfig @@ -0,0 +1,8 @@ +root = true + +[{*.{c,h,},Makefile,Makefile.*}] +charset = utf-8 +end_of_line = lf +insert_final_newline = true +indent_style = tab +indent_size = 8 From a6761e342366188ceeb792fdcb0de4783b1d2c4e Mon Sep 17 00:00:00 2001 From: Nathan Lynch Date: Wed, 24 Jul 2024 14:22:01 -0500 Subject: [PATCH 2/3] librtas: include stdio.h for printf() in internal.h The dbg() macro in internal.h expands to a printf() call; internal.h ought to include stdio.h. Signed-off-by: Nathan Lynch --- librtas_src/internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/librtas_src/internal.h b/librtas_src/internal.h index 97411d3..ab7d6e4 100644 --- a/librtas_src/internal.h +++ b/librtas_src/internal.h @@ -24,6 +24,7 @@ #define LIBRTAS_INTERNAL_H #include +#include #define WORK_AREA_SIZE 4096 #define MAX_ARGS 16 From 648e47a778b93e7515f41733de58cb66abd1a86d Mon Sep 17 00:00:00 2001 From: Nathan Lynch Date: Tue, 23 Jul 2024 10:08:08 -0500 Subject: [PATCH 3/3] librtas: sort librtas_la_SOURCES Signed-off-by: Nathan Lynch --- Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 67257e3..2fbfbf4 100644 --- a/Makefile.am +++ b/Makefile.am @@ -28,11 +28,11 @@ LIBRTAS_LIBRARY_VERSION = $(LIBRTAS_CURRENT):$(LIBRTAS_REVISION):$(LIBRTAS_AGE) lib_LTLIBRARIES += librtas.la librtas_la_LDFLAGS = -version-info $(LIBRTAS_LIBRARY_VERSION) -lpthread librtas_la_SOURCES = \ - librtas_src/vpd.c \ librtas_src/ofdt.c \ librtas_src/syscall_calls.c \ librtas_src/syscall_rmo.c \ - librtas_src/sysparm.c + librtas_src/sysparm.c \ + librtas_src/vpd.c library_include_HEADERS += librtas_src/librtas.h noinst_HEADERS += \