fix: alias/sourcemap/bundle_mode bug (#651)

* fix: bundle mode with start command should be development environment instead of production
* fix: alias is should be working for .d.ts file
* fix: sourcemap option should be working and default should be false for transform

Author: XGHeaven

.changeset/new-pears-arrive.md

@@ -0,0 +1,5 @@
+---
+'@ice/pkg': patch
+---
+
+fix: bundle mode with start command should be `development` environment instead of `production`

.changeset/plenty-avocados-know.md

@@ -0,0 +1,5 @@
+---
+'@ice/pkg': patch
+---
+
+fix: alias is should be working for .d.ts file

.changeset/sweet-plums-rush.md

@@ -0,0 +1,5 @@
+---
+'@ice/pkg': patch
+---
+
+fix: sourcemap option should be working and default should be false for transform

.gitignore

@@ -33,6 +33,7 @@ packages/*/es/
 /packages/**/es2017
 /packages/**/cjs
 /packages/**/esm
+/packages/pkg/tests/fixtures/**/build.config.for-test.mts
 **/node_modules
 /.pnpm-debug.log
 **/pnpm-global

packages/pkg/src/helpers/dts.ts

@@ -127,7 +127,10 @@ export async function dtsCompile({ files, alias, rootDir, outputDir }: DtsCompil
   // Reason: https://github.com/microsoft/TypeScript/issues/30952#issuecomment-1114225407
   const tsConfigLocalPath = path.join(rootDir, 'node_modules/pkg/tsconfig.json');
   await fse.ensureFile(tsConfigLocalPath);
-  await fse.writeJSON(tsConfigLocalPath, tsConfig, { spaces: 2 });
+  await fse.writeJSON(tsConfigLocalPath, {
+    ...tsConfig,
+    compilerOptions: tsConfig.options,
+  }, { spaces: 2 });
 
   const runFile = await prepareSingleFileReplaceTscAliasPaths({
     configFile: tsConfigLocalPath,

packages/pkg/src/helpers/getBuildTasks.ts

@@ -28,6 +28,9 @@ function getBuildTask(buildTask: BuildTask, context: Context): BuildTask {
 
   config.sourcemap = config.sourcemap ?? command === 'start';
 
+  const mode = command === 'build' ? 'production' : 'development';
+  config.modes = [mode];
+
   if (config.type === 'bundle') {
     const defaultBundleSwcConfig = getDefaultBundleSwcConfig(config, context, taskName);
     config.swcCompileOptions = typeof config.modifySwcCompileOptions === 'function' ?
@@ -38,8 +41,6 @@ function getBuildTask(buildTask: BuildTask, context: Context): BuildTask {
       );
   } else if (config.type === 'transform') {
     config.outputDir = getTransformDefaultOutputDir(rootDir, taskName);
-    const mode = command === 'build' ? 'production' : 'development';
-    config.modes = [mode];
     const defaultTransformSwcConfig = getDefaultTransformSwcConfig(config, context, taskName, mode);
     config.swcCompileOptions = typeof config.modifySwcCompileOptions === 'function' ?
       config.modifySwcCompileOptions(defaultTransformSwcConfig) :

packages/pkg/src/tasks/transform.ts

@@ -94,6 +94,10 @@ async function runTransform(
   const logger = createLogger(`${taskName}-${mode}`);
   const entryDirs = getTransformEntryDirs(rootDir, config.entry as Record<string, string>);
 
+  if (config.sourcemap === 'inline') {
+    logger.warn('The sourcemap "inline" for transform has not fully supported.');
+  }
+
   const files: OutputFile[] = [];
 
   if (updatedFile) {
@@ -180,7 +184,8 @@ async function runTransform(
       }
     }
 
-    if (map) {
+    // IMPROVE: should disable sourcemap generation in the transform step for speed.
+    if (map && config.sourcemap !== false) {
       const standardizedMap = typeof map === 'string' ? map : JSON.stringify(map);
 
       fs.writeFileSync(

packages/pkg/tests/fixtures/alias/build.config.default.mts

@@ -0,0 +1,11 @@
+import { defineConfig } from '@ice/pkg';
+
+// https://pkg.ice.work/reference/config-list
+export default defineConfig({
+  transform: {
+    formats: ['cjs', 'esm', 'es2017']
+  },
+  alias: {
+    '@': './src'
+  },
+});

packages/pkg/tests/fixtures/alias/package.json

@@ -0,0 +1,8 @@
+{
+  "name": "@ice/pkg-tests-fixtures-alias",
+  "private": true,
+  "dependencies": {
+    "@ice/pkg": "workspace:*"
+  },
+  "version": null
+}

packages/pkg/tests/fixtures/alias/src/alias.ts

@@ -0,0 +1 @@
+export const bar = 2