Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace wai-middleware-metrics with prometheus-wai-middleware #23

Open
adinapoli opened this issue Jan 21, 2021 · 0 comments
Open

Replace wai-middleware-metrics with prometheus-wai-middleware #23

adinapoli opened this issue Jan 21, 2021 · 0 comments

Comments

@adinapoli
Copy link
Contributor

It seems like during the upgrade to 8.10, something broke the wai-middleware-metrics library, so that we cannot report as metrics the number of HTTP requests for 5xx/4xx etc.

I have taken a quick look at this and it seems like the counters and gauges are regularly registered inside the EKG Store, but that somehow the prometheus library decides not to render them.

This might due to the changes to the prometheus format (i.e. from V1 to V2) or some other bugs. Having said that, I see two ways out:

  • We crib/fork the wai-middleware-metrics and we remove the xxx from the registered metrics. I have a hunch that might
    be the bit that Prometheus doesn't like;

  • We swap the library in favour of prometheus-wai-middleware, that should integrate more tightly with the prometheus
    library. The only problem is that the former requires prometheus >= 2.2, but we are stuck with 2.1.2, so we will need a
    bit of massaging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant