Fill in blank exception messages

[tjlaboss]

Issue #800 identified blank TypeError messages in material.py. While specifying a message is optional in Python, if an exception does include a message, it should not be blank.

Here are the instances:

---

data_inputs/material.py

L65

 def __setitem__(self, key, value):
        key = self._validate_key(key)
        if not isinstance(value, (Library, str)):
            raise TypeError("")

L94

    @staticmethod
    def _validate_key(key):
        if not isinstance(key, (str, LibraryType)):
            raise TypeError("")
        if not isinstance(key, LibraryType):
            key = LibraryType(key.upper())
        return key

---

numbered_object_collection.py

L362

    def remove(self, delete):
        """Removes the given object from the collection.

        Parameters
        ----------
        delete : Numbered_MCNP_Object
            the object to delete
        """
        if not isinstance(delete, self._obj_class):
            raise TypeError("")
        candidate = self[delete.number]
        if delete is candidate:
            del self[delete.number]
        else:
            raise KeyError(f"This object is not in this collection")

---

There is also another case in input_parser/syntax_node.py at L1967 that appears to be intentional (creating the warning in a roundabout way).

[tjlaboss]

There is also a bare raise TypeError in data_inputs/nuclide.py at L347: this one appears to be intentionally bare.

    def __lt__(self, other):
        if not isinstance(other, type(self)):
            raise TypeError
        return (self.Z, self.A, self.meta_state) < (other.Z, other.A, other.meta_state)

[MicahGale]

I feel like this was laziness on my part that I meant to come back to and forgot to do so.

[digvijay-y]

is it done? or can I work on it?

[MicahGale]

Yes this up for the taking. #802 was erroneously linked to this issue.