Building the application

[Giovar6]

Hi all. I am installing MOOSE on a new computer, and I am facing some issues in compiling the application I used to use on a old computer.
MOOSE is currently installed on a desktop computer with Ubuntu 22.04.
When compiling the application I recieve the following errors:

Creating Unity /home/giovannir/projects/mufasa/build/unity_src/base_Unity.C
Compiling C++ (in opt mode) /home/giovannir/projects/mufasa/test/src/base/mufasaTestApp.C...
Compiling C++ (in opt mode) /home/giovannir/projects/mufasa/build/unity_src/base_Unity.C...
Linking Test Library /home/giovannir/projects/mufasa/test/lib/libmufasa_test-opt.la...
In file included from /home/giovannir/projects/moose/framework/build/header_symlinks/MooseApp.h:18,
                 from /home/giovannir/projects/mufasa/build/header_symlinks/mufasaApp.h:15,
                 from /home/giovannir/projects/mufasa/src/base/mufasaApp.C:1,
                 from /home/giovannir/projects/mufasa/build/unity_src/base_Unity.C:2:
/home/giovannir/projects/mufasa/src/base/mufasaApp.C: In static member function 'static void mufasaApp::associateSyntax(Factory&, ActionFactory&, Syntax&)':
/home/giovannir/projects/moose/framework/build/header_symlinks/ActionFactory.h:26:3: error: invalid use of member function 'Syntax& MooseApp::syntax()' (did you forget the '()' ?)
   26 |   syntax.registerActionSyntax(action, action_syntax, "", __FILE__, __LINE__)
      |   ^~~~~~
/home/giovannir/projects/moose/framework/build/header_symlinks/ActionFactory.h:26:3: note: in definition of macro 'registerSyntax'
   26 |   syntax.registerActionSyntax(action, action_syntax, "", __FILE__, __LINE__)
      |   ^~~~~~
/home/giovannir/projects/moose/framework/build/header_symlinks/ActionFactory.h:26:3: error: invalid use of member function 'Syntax& MooseApp::syntax()' (did you forget the '()' ?)
   26 |   syntax.registerActionSyntax(action, action_syntax, "", __FILE__, __LINE__)
      |   ^~~~~~
/home/giovannir/projects/moose/framework/build/header_symlinks/ActionFactory.h:26:3: note: in definition of macro 'registerSyntax'
   26 |   syntax.registerActionSyntax(action, action_syntax, "", __FILE__, __LINE__)
      |   ^~~~~~
/home/giovannir/projects/moose/framework/build/header_symlinks/ActionFactory.h:26:3: error: invalid use of member function 'Syntax& MooseApp::syntax()' (did you forget the '()' ?)
   26 |   syntax.registerActionSyntax(action, action_syntax, "", __FILE__, __LINE__)
      |   ^~~~~~
/home/giovannir/projects/moose/framework/build/header_symlinks/ActionFactory.h:26:3: note: in definition of macro 'registerSyntax'
   26 |   syntax.registerActionSyntax(action, action_syntax, "", __FILE__, __LINE__)
      |   ^~~~~~
/home/giovannir/projects/moose/framework/build/header_symlinks/ActionFactory.h:26:3: error: invalid use of member function 'Syntax& MooseApp::syntax()' (did you forget the '()' ?)
   26 |   syntax.registerActionSyntax(action, action_syntax, "", __FILE__, __LINE__)
      |   ^~~~~~
/home/giovannir/projects/moose/framework/build/header_symlinks/ActionFactory.h:26:3: note: in definition of macro 'registerSyntax'
   26 |   syntax.registerActionSyntax(action, action_syntax, "", __FILE__, __LINE__)
      |   ^~~~~~
/home/giovannir/projects/moose/framework/build/header_symlinks/ActionFactory.h:26:3: error: invalid use of member function 'Syntax& MooseApp::syntax()' (did you forget the '()' ?)
   26 |   syntax.registerActionSyntax(action, action_syntax, "", __FILE__, __LINE__)
      |   ^~~~~~
/home/giovannir/projects/moose/framework/build/header_symlinks/ActionFactory.h:26:3: note: in definition of macro 'registerSyntax'
   26 |   syntax.registerActionSyntax(action, action_syntax, "", __FILE__, __LINE__)
      |   ^~~~~~
make: *** [/home/giovannir/projects/moose/framework/build.mk:151: /home/giovannir/projects/mufasa/build/unity_src/base_Unity.x86_64-conda-linux-gnu.opt.lo] Errore 1

I think the issue is the mufasaApp.C when I use the registerSyntax("",""), But I son't know how to solve.
Thank you in advance!

[GiudGiud]

Hello

How old is mufasaApp?
And which moose submodule are you using?

Guillaume

[Giovar6]

Hello GiudGiud,
Mufasa Is derived from Crow, but I've updated at the end of 2022.
The submodules are:

• heat conduction
• misc
• phase field
• tensor mechanics

[GiudGiud]

I think you need to update it again.
Look at a more model XXXApp.C file for an example. for example in the modules or in Cardinal

btw two of these modules have changed names. Heat transfer and solid mechanics

[Giovar6]

Thanks for the suggestions!
I guessed I would have needed to update again. I'll work on this and I'll let you know.

[Giovar6]

Hello,
I tried to follow the advice an I found out that the use of associateSyntax is deprecated and I should use registerAll.
Which sintax should I use in this case?
Anyway, following the PhaseFieldApp.C i included the following code in my .C file:

void`
PhaseFieldApp::associateSyntax(Syntax & syntax, ActionFactory & action_factory)
{
  mooseDeprecated("use registerAll instead of associateSyntax");
  Registry::registerActionsTo(action_factory, {"PhaseFieldApp"});
  associateSyntaxInner(syntax, action_factory);
}

Whith this code I was able to build my application.
However, as soon as I try to run a simulation with peacock I receive this error:

*** ERROR ***
/home/giovannir/projects/mufasa/problems/ThreePartBase/peacock_run_mesh_tmp.i:117: missing required parameter 'Kernels/PolycrystalSinteringKernel/type'
	Doc String: "A string representing the Moose Object that will be built by this Action"

I suppose this means that the PolycristalSinteringKernel is not correctly compiled or linked?
I report here below the Code of mufasaApp.C in the old version

#include "AppFactory.h"
#include "MufasaApp.h"
#include "Moose.h"
#include "MooseSyntax.h"

#include "HeatConductionApp.h"
#include "MiscApp.h"
#include "PhaseFieldApp.h"
#include "TensorMechanicsApp.h"

#ifdef MARMOT_ENABLED
#include "MarmotApp.h"
#endif

/*#include "CrowRevision.h" */
InputParameters
MufasaApp::validParams()
{
  InputParameters params = MooseApp::validParams();
  return params;
}

registerKnownLabel("MufasaApp");

MufasaApp::MufasaApp(const InputParameters &parameters) : MooseApp(parameters) {
  MufasaApp::registerAll(_factory, _action_factory, _syntax);
}

MufasaApp::~MufasaApp() {}

void MufasaApp::associateSyntax(Syntax &syntax,
                              ActionFactory & /*action_factory*/) {
  registerSyntax("PolycrystalSinteringKernelAction",
                 "Kernels/PolycrystalSinteringKernel");
  registerSyntax("PolycrystalSinteringMaterialAction",
                 "Materials/PolycrystalSinteringMaterial");
  registerSyntax("TwoParticleGrainsICAction",
                 "ICs/PolycrystalICs/TwoParticleGrainsIC");
  registerSyntax("BicrystalICAction", "ICs/PolycrystalICs/BicrystalIC");
  registerSyntax("MultiSmoothParticleICAction",
                 "ICs/PolycrystalICs/MultiSmoothParticleIC");
}

// External entry point for dynamic application loading
extern "C" void MufasaApp__registerApps() { MufasaApp::registerApps(); }
void MufasaApp::registerApps() { registerApp(MufasaApp); }

// External entry point for object registration
extern "C" void MufasaApp__registerAll(Factory &factory,
                                     ActionFactory &action_factory,
                                     Syntax &syntax) {
  MufasaApp::registerAll(factory, action_factory, syntax);
}
void MufasaApp::registerAll(Factory &factory, ActionFactory &action_factory,
                          Syntax &syntax) {
  Registry::registerObjectsTo(factory, {"MufasaApp"});
  Registry::registerActionsTo(action_factory, {"MufasaApp"});
  MufasaApp::associateSyntax(syntax, action_factory);

  PhaseFieldApp::registerAll(factory, action_factory, syntax);
  TensorMechanicsApp::registerAll(factory, action_factory, syntax);
  HeatConductionApp::registerAll(factory, action_factory, syntax);
  MiscApp::registerAll(factory, action_factory, syntax);

#ifdef MARMOT_ENABLED
  MarmotApp::registerAll(factory, action_factory, syntax);
#endif
}

Thanks in advance for any help!

[GiudGiud]

Hello

This still looks deprecated.

Can you follow the tutorial for making a new application, and use the stork script in moose/scripts to make a new app. This new app will have the XXApp.C file the right way so you can use it as an example

Guillaume

[HPL001]

@Giovar6 Hello, I am learning MOOSE and Crow. But I can't find Crow that matches the current MOOSE distribution. Can you give me some advice?

[Giovar6]

Hello @HPL001. Starting from the suggestion of @GiudGiud and other people here in the forum, I have started from Crow and updated to work with the current version of MOOSE. To do this, I suggest creating a new app and compare the sintax of crow to the one of the new app. Rewrite the sintax of crow so that it match the new app. This should solve your issue.

[GiudGiud]

@Giovar6 did you upload your work to your fork? I dont see it.

There is significant interest around Crow. If a Crow user could officially take care of maintaining a working version we could help them do that