Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No longer require single Closures to be supplied to flow channels #29594

Open
1 task
joshuahansel opened this issue Dec 20, 2024 · 1 comment · Fixed by #29752
Open
1 task

No longer require single Closures to be supplied to flow channels #29594

joshuahansel opened this issue Dec 20, 2024 · 1 comment · Fixed by #29752
Assignees
@joshuahansel
Labels
C: Modules/Thermal Hydraulics Tickets pertaining to the thermal_hydraulics module T: task An enhancement to the software.

Comments

@joshuahansel
Copy link
Contributor

joshuahansel commented Dec 20, 2024 •
edited
Loading

Motivation

The flexibility of the Closures system could be increased by not requiring each Closures object to supply all of the necessary closures. For example, one could do this:

closures = 'my_friction_closures my_heat_transfer_closures'

This allows Closures classes to be more natural, since they don't need to have a combination of types of closure relations.

Design

The closures parameter in FlowChannelBase will now correspond to a vector of Closures names, and it will be optional, defaulting to empty. Then all of the places using it will loop over the provided closures.

  • Delete Closures1PhaseNone

Impact

Enhanced flexibility.
@joshuahansel joshuahansel added T: task An enhancement to the software. C: Modules/Thermal Hydraulics Tickets pertaining to the thermal_hydraulics module labels Dec 20, 2024
@joshuahansel joshuahansel self-assigned this Dec 20, 2024
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jan 10, 2025
@joshuahansel
Allowed multiple Closures to be supplied
361d444 
Refs idaholab#29594
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jan 10, 2025
@joshuahansel
Added FunctorClosures and demonstrated using multiple closures
fc889bc 
Closes idaholab#29594
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jan 23, 2025
@joshuahansel
Allowed multiple Closures to be supplied
baaf595 
Refs idaholab#29594
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jan 23, 2025
@joshuahansel
Added FunctorClosures and demonstrated using multiple closures
9e8829a 
Closes idaholab#29594
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jan 27, 2025
@joshuahansel
Allowed multiple Closures to be supplied
b3dc307 
Refs idaholab#29594
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jan 27, 2025
@joshuahansel
Added FunctorClosures and demonstrated using multiple closures
4e2a3a6 
Closes idaholab#29594
@joshuahansel joshuahansel mentioned this issue Jan 27, 2025
Merged
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jan 27, 2025
@joshuahansel
Removed unnecessary material property from T_avg material
c2595c9 
The average wall temperature material required an average wall
heat transfer coefficient material, but this quantity can be
computed directly from the other parameters, so the parameter
was removed to ease requirements of the material.

Refs idaholab#29594
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jan 27, 2025
@joshuahansel
Added WallTemperature1PhaseClosures
99eff7b 
Refs idaholab#29594
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jan 27, 2025
@joshuahansel
Deprecated Closures1PhaseNone
979bb9c 
Refs idaholab#29594
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jan 28, 2025
@joshuahansel
Restricted test to require air submodule
49e7c5c 
Refs idaholab#29594
@joshuahansel
Copy link
Contributor Author

Re-opening until Closures1PhaseNone is removed.

@joshuahansel joshuahansel reopened this Jan 28, 2025
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jan 31, 2025
@joshuahansel
Allowed multiple Closures to be supplied
cfedfbc 
Refs idaholab#29594
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jan 31, 2025
@joshuahansel
Added FunctorClosures and demonstrated using multiple closures
31cddcb 
Closes idaholab#29594
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jan 31, 2025
@joshuahansel
Deleted deprecated _closures member
f440d84 
Refs idaholab#29594
@joshuahansel joshuahansel mentioned this issue Jan 31, 2025
Merged
5 tasks
tophmatthews pushed a commit to tophmatthews/moose that referenced this issue Mar 6, 2025
@joshuahansel @tophmatthews
Deleted deprecated _closures member
dfb860d 
Refs idaholab#29594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuahansel joshuahansel

Labels
C: Modules/Thermal Hydraulics Tickets pertaining to the thermal_hydraulics module T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow multiple (or no) Closures on a flow channel joshuahansel/moose
1 participant
@joshuahansel