Skip to content

Small fix to compile with gcc 4.9 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slosar wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Small fix to compile with gcc 4.9 #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions likely/Random.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

#include <cstddef>
#include <vector>
#include <stdint.h>
Copy link
Collaborator

@dkirkby dkirkby Aug 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if <stdint> works also, since the .h is normally not required.

Copy link
Contributor Author

@slosar slosar Aug 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, on my machine you do need .h. Weird, isn't it?

anže

On Sun, 16 Aug 2015, dkirkby wrote:

@@ -11,6 +11,7 @@

#include
#include
+#include <stdint.h>

Can you check if works also, since the .h is normally not required.

Reply to this email directly or view it on GitHub:
https://github.com/deepzot/likely/pull/7/files#r37148585

Copy link
Collaborator

@dkirkby dkirkby Aug 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant <cstdint>. You are generally supposed to include <cxxx> instead of <xxx.h> in C++, with the only difference being that the C++ version wraps everything in a namespace, to avoid polluting the global namespace.

Copy link
Contributor Author

@slosar slosar Aug 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm, it works but requires compiler option to enable c++11, e.g.

/usr/include/c++/4.9/bits/c++0x_warning.h:32:2: error: #error This file
requires compiler and library support for the ISO C++ 2011 standard. This
support is currently experimental, and must be enabled with the -std=c++11
or -std=gnu++11 compiler options.
#error This file requires compiler and library support for the
...

anže

On Sat, 22 Aug 2015, dkirkby wrote:

@@ -11,6 +11,7 @@

#include
#include
+#include <stdint.h>

Sorry, I meant <cstdint>. You are generally supposed to include <cxxx> instead of <xxx.h> in C++, with the only difference being that the C++ version wraps everything in a namespace, to avoid polluting the global namespace.

Reply to this email directly or view it on GitHub:
https://github.com/deepzot/likely/pull/7/files#r37701122


namespace likely {
class Random {
Expand Down