feat: add possibility to scaffold underscore package (#4880)

Author: Pantani

changelog.md

@@ -4,6 +4,7 @@
 
 ### Changes
 
+- [#4880](https://github.com/ignite/cli/pull/4880) Add possibility to scaffold underscore package.
 - [#4878](https://github.com/ignite/cli/pull/4878) Improve the `xast` package readability.
 
 ## [`v29.8.0`](https://github.com/ignite/cli/releases/tag/v29.8.0)

ignite/pkg/gomodulepath/gomodulepath.go

@@ -154,6 +154,6 @@ func root(path string) string {
 }
 
 func stripNonAlphaNumeric(name string) string {
-	reg := regexp.MustCompile(`[^a-zA-Z0-9]+`)
+	reg := regexp.MustCompile(`[^a-zA-Z0-9_]+`)
 	return strings.ToLower(reg.ReplaceAllString(name, ""))
 }

ignite/pkg/gomodulepath/gomodulepath_test.go

@@ -63,7 +63,7 @@ func TestParse(t *testing.T) {
 		{
 			name:    "with underscore",
 			rawpath: "github.com/a/b_c",
-			path:    Path{RawPath: "github.com/a/b_c", Root: "b_c", Package: "bc"},
+			path:    Path{RawPath: "github.com/a/b_c", Root: "b_c", Package: "b_c"},
 		},
 		{
 			name:    "with mixed case",
@@ -78,7 +78,7 @@ func TestParse(t *testing.T) {
 		{
 			name:    "with a name containing underscore",
 			rawpath: "a_b",
-			path:    Path{RawPath: "a_b", Root: "a_b", Package: "ab"},
+			path:    Path{RawPath: "a_b", Root: "a_b", Package: "a_b"},
 		},
 		{
 			name:    "with a name containing dash",
@@ -93,7 +93,7 @@ func TestParse(t *testing.T) {
 		{
 			name:    "with a path containing underscore",
 			rawpath: "a/b_c",
-			path:    Path{RawPath: "a/b_c", Root: "b_c", Package: "bc"},
+			path:    Path{RawPath: "a/b_c", Root: "b_c", Package: "b_c"},
 		},
 		{
 			name:    "with a path containing dash",

ignite/services/scaffolder/init.go

@@ -9,6 +9,7 @@ import (
 	"github.com/ignite/cli/v29/ignite/pkg/cliui"
 	"github.com/ignite/cli/v29/ignite/pkg/errors"
 	"github.com/ignite/cli/v29/ignite/pkg/gomodulepath"
+	"github.com/ignite/cli/v29/ignite/pkg/multiformatname"
 	"github.com/ignite/cli/v29/ignite/pkg/xgenny"
 	"github.com/ignite/cli/v29/ignite/templates/app"
 	"github.com/ignite/cli/v29/ignite/templates/field"
@@ -119,8 +120,13 @@ func generate(
 	}
 
 	if !noDefaultModule {
+		moduleName, err := multiformatname.NewName(pathInfo.Package, multiformatname.NoNumber)
+		if err != nil {
+			return smc, err
+		}
+
 		opts := &modulecreate.CreateOptions{
-			ModuleName: pathInfo.Package, // App name
+			ModuleName: moduleName.LowerCase, // App module
 			ModulePath: pathInfo.RawPath,
 			AppName:    pathInfo.Package,
 			ProtoDir:   protoDir,

integration/app/cmd_app_test.go

@@ -216,3 +216,19 @@ func TestGenerateAnAppWithDefaultDenom(t *testing.T) {
 
 	app.EnsureSteady()
 }
+
+func TestScaffoldModuleWithUnderscoreAppName(t *testing.T) {
+	var (
+		env = envtest.New(t)
+		app = env.ScaffoldApp("github.com/test/space_chain")
+	)
+
+	app.Scaffold(
+		"create a module in app with underscore name",
+		false,
+		"module",
+		"f_o_o",
+	)
+
+	app.EnsureSteady()
+}