Merge branch 'main' into fix/scaffold-type-after-msg

Author: Pantani

changelog.md

@@ -15,6 +15,7 @@
 ### Fixes
 
 - [#4886](https://github.com/ignite/cli/pull/4886) Fix chain scaffolding checks.
+- [#4889](https://github.com/ignite/cli/pull/4889) Plugin data race.
 
 ## [`v29.8.0`](https://github.com/ignite/cli/releases/tag/v29.8.0)
 

ignite/internal/plugin/execute.go

@@ -12,10 +12,28 @@ import (
 	"github.com/ignite/cli/v29/ignite/services/plugin"
 )
 
+type synchronizedBuffer struct {
+	mu  sync.Mutex
+	buf bytes.Buffer
+}
+
+func (b *synchronizedBuffer) Write(p []byte) (int, error) {
+	b.mu.Lock()
+	defer b.mu.Unlock()
+
+	return b.buf.Write(p)
+}
+
+func (b *synchronizedBuffer) String() string {
+	b.mu.Lock()
+	defer b.mu.Unlock()
+
+	return b.buf.String()
+}
+
 // Execute starts and executes a plugin, then shutdowns it.
 func Execute(ctx context.Context, path string, args []string, options ...plugin.APIOption) (string, error) {
-	var buf bytes.Buffer
-	var mu sync.Mutex
+	var buf synchronizedBuffer
 	plugins, err := plugin.Load(
 		ctx,
 		[]pluginsconfig.Plugin{{Path: path}},
@@ -40,7 +58,5 @@ func Execute(ctx context.Context, path string, args []string, options ...plugin.
 	}
 
 	plugins[0].KillClient()
-	mu.Lock()
-	defer mu.Unlock()
 	return buf.String(), err
 }