Debug

ikalnytskyi · Aug 11, 2024 · 686f201 · 686f201
1 parent 6bb2488
commit 686f201
Show file tree

Hide file tree

Showing 2 changed files with 78 additions and 65 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -6,7 +6,7 @@ on:
   pull_request:
     branches: [ master ]
   schedule:
-    - cron: "0 8 * * *"
+    - cron: "@weekly"
 
 defaults:
   run:
@@ -18,13 +18,13 @@ jobs:
     strategy:
       matrix:
         os:
-          - ubuntu-20.04
-          - ubuntu-22.04
-          - ubuntu-24.04
-          - macos-12
-          - macos-13
-          - macos-14  # M1 CPU
-          - windows-2019
+          # - ubuntu-20.04
+          # - ubuntu-22.04
+          # - ubuntu-24.04
+          # - macos-12
+          # - macos-13
+          # - macos-14
+          # - windows-2019
           - windows-2022
     steps:
       - uses: actions/checkout@v4
@@ -49,43 +49,43 @@ jobs:
           EXPECTED_SERVICE_NAME: postgres
           EXPECTED_SERVER_VERSION: "16"
 
-  parametrized:
-    runs-on: ${{ matrix.os }}
-    strategy:
-      matrix:
-        os:
-          - ubuntu-latest
-          - macos-latest
-          - windows-latest
-        postgres-version:
-          - "13"
-          - "14"
-          - "15"
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Run setup-postgres
-        uses: ./
-        with:
-          username: yoda
-          password: GrandMaster
-          database: jedi_order
-          port: 34837
-          postgres-version: ${{ matrix.postgres-version }}
-        id: postgres
-
-      - name: Run setup-python
-        uses: actions/setup-python@v5
-        with:
-          python-version: "3.10"
-
-      - name: Run tests
-        run: |
-          python3 -m pip install --upgrade pip pytest psycopg furl
-          python3 -m pytest -vv test_action.py
-        env:
-          CONNECTION_URI: ${{ steps.postgres.outputs.connection-uri }}
-          SERVICE_NAME: ${{ steps.postgres.outputs.service-name }}
-          EXPECTED_CONNECTION_URI: postgresql://yoda:GrandMaster@localhost:34837/jedi_order
-          EXPECTED_SERVICE_NAME: yoda
-          EXPECTED_SERVER_VERSION: ${{ matrix.postgres-version }}
+  # parametrized:
+  #   runs-on: ${{ matrix.os }}
+  #   strategy:
+  #     matrix:
+  #       os:
+  #         - ubuntu-latest
+  #         - macos-latest
+  #         - windows-latest
+  #       postgres-version:
+  #         - "13"
+  #         - "14"
+  #         - "15"
+  #   steps:
+  #     - uses: actions/checkout@v4
+  #
+  #     - name: Run setup-postgres
+  #       uses: ./
+  #       with:
+  #         username: yoda
+  #         password: GrandMaster
+  #         database: jedi_order
+  #         port: 34837
+  #         postgres-version: ${{ matrix.postgres-version }}
+  #       id: postgres
+  #
+  #     - name: Run setup-python
+  #       uses: actions/setup-python@v5
+  #       with:
+  #         python-version: "3.10"
+  #
+  #     - name: Run tests
+  #       run: |
+  #         python3 -m pip install --upgrade pip pytest psycopg furl
+  #         python3 -m pytest -vv test_action.py
+  #       env:
+  #         CONNECTION_URI: ${{ steps.postgres.outputs.connection-uri }}
+  #         SERVICE_NAME: ${{ steps.postgres.outputs.service-name }}
+  #         EXPECTED_CONNECTION_URI: postgresql://yoda:GrandMaster@localhost:34837/jedi_order
+  #         EXPECTED_SERVICE_NAME: yoda
+  #         EXPECTED_SERVER_VERSION: ${{ matrix.postgres-version }}
diff --git a/action.yml b/action.yml
@@ -35,40 +35,50 @@ outputs:
 runs:
   using: composite
   steps:
-    - name: Cache PostgreSQL installation packages
-      uses: actions/cache@v3
+    # - name: Cache PostgreSQL installation packages
+    #   uses: actions/cache@v3
+    #   with:
+    #     key: ${{ runner.os }}-postgres-${{ inputs.postgres-version }}
+    #     path: |
+    #       /var/cache/apt/archives
+    #       C:\Users\<username>\AppData\Local\Temp\chocolatey
+
+    - uses: mxschmitt/action-tmate@v3
       with:
-        key: ${{ runner.os }}-postgres-${{ inputs.postgres-version }}
-        path: |
-          /var/cache/apt/archives
-          C:\Users\<username>\AppData\Local\Temp\chocolatey
+        limit-access-to-actor: false
 
     - name: Install PostgreSQL
       run: |
+        if [[ ! "${{ inputs.postgres-version }}" =~ ^(13|14|15|16)$ ]]; then
+          echo "::error::postgres-version must be one of: 13, 14, 15, 16."
+          exit 1
+        fi
+
         if [ "$RUNNER_OS" == "Linux" ]; then
-          echo "deb http://apt.postgresql.org/pub/repos/apt $(lsb_release -cs)-pgdg main" \
-            | sudo tee /etc/apt/sources.list.d/pgdg.list
-          wget --quiet -O - https://www.postgresql.org/media/keys/ACCC4CF8.asc | sudo apt-key add -
+          APT_ENTRY="deb http://apt.postgresql.org/pub/repos/apt $(lsb_release -cs)-pgdg main"
+          APT_KEY="https://www.postgresql.org/media/keys/ACCC4CF8.asc"
+
+          echo "$APT_ENTRY" | sudo tee /etc/apt/sources.list.d/pgdg.list
+          wget --quiet -O - "$APT_KEY" | sudo apt-key add -
           sudo apt-get update
           sudo apt-get -y install postgresql-${{ inputs.postgres-version }}
 
-          # Add PostgreSQL binaries to PATH, so they become globally available.
           /usr/lib/postgresql/${{ inputs.postgres-version }}/bin/pg_config --bindir >> $GITHUB_PATH
-        elif [ "$RUNNER_OS" == "Windows" ]; then
-          echo "$PGBIN" >> $GITHUB_PATH
-          echo "PQ_LIB_DIR=$PGROOT\lib" >> $GITHUB_ENV
 
+        elif [ "$RUNNER_OS" == "Windows" ]; then
           # The Windows runner has some PostgreSQL environment variables set
           # that may confuse users since they may be irrelevant to the
-          # PostgreSQL server we're using.
+          # PostgreSQL server we're using. Since GitHub actions does not
+          # support unsetting environment variables, the best we can do is to
+          # clear their values in order to indicate they must not be used.
           for name in "PGROOT" "PGDATA" "PGBIN" "PGUSER" "PGPASSWORD"; do
             echo "$name=" >> $GITHUB_ENV
           done
 
           # FIXME: Aargh! For reasons unknown the '--servicename' option is
-          # ignored when installing a PostgreSQL version that is already
-          # preinstalled on GitHub runners. In order to bypass the issue I'm
-          # using default naming convention to overwrite the service name.
+          # ignored when installing a PostgreSQL version that come preinstalled
+          # on the GitHub runners. In order to bypass the issue I'm using
+          # default naming convention to overwrite the service name.
           choco install postgresql${{ inputs.postgres-version }} \
             --ia "--servicename postgresql-${{ runner.arch }}-${{ inputs.postgres-version }}"
 
@@ -83,6 +93,9 @@ runs:
           export PGROOT="$PROGRAMFILES/PostgreSQL/${{ inputs.postgres-version }}"
           "$PGROOT"/bin/pg_config.exe --bindir >> $GITHUB_PATH
           echo "PQ_LIB_DIR=$("$PGROOT"/bin/pg_config.exe --libdir)" >> $GITHUB_ENV
+
+          # echo "$PGBIN" >> $GITHUB_PATH
+          # echo "PQ_LIB_DIR=$PGROOT\lib" >> $GITHUB_ENV
         elif [ "$RUNNER_OS" == "macOS" ]; then
           case "$(sw_vers -productVersion)" in
             13.*|14.*)