Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid syntax in .def, .air, and.cns are ignored (Apparently accurate to Mugen) #2143

Open
jenngra505 opened this issue Nov 23, 2024 · 1 comment
Labels
etc Everything else

Comments

@jenngra505
Copy link

jenngra505 commented Nov 23, 2024

Describe the bug

Various syntax errors are ignored, all of which have been compiled into a single test character.

.Def syntax:
Having the starting line of the .def be an uncommented sequence of alphanumeric characters does not crash the engine for some reason.

.Air syntax:
Once the character is loaded the .air file can contain uncommented string values and Unicode.

.Cns syntax:
Life, power, attack, and defence will accept string values for some reaosn.

To Reproduce

  1. Download La Vanguardia by Nomi https://www.mediafire.com/file/tu6osgfrntuwnzs/La_Vanguardia.rar/file
  2. Start Character
  3. Witness Character Load

Expected behavior

Engine crashes upon attempting to load character.

Screenshots / Video

No response

Engine Version (or source code date)

v0.99

Operating system

Windows

Extra context or search terms

No response

@jenngra505 jenngra505 changed the title Arbitrary Code Execution in several areas of character bytecode. Security: Arbitrary Code Execution in several areas of character bytecode. Nov 23, 2024
@jenngra505 jenngra505 changed the title Security: Arbitrary Code Execution in several areas of character bytecode. Invalid syntax in .def and .air are ignored Nov 23, 2024
@jenngra505 jenngra505 changed the title Invalid syntax in .def and .air are ignored Invalid syntax in .def, .air, and.cns are ignored Nov 23, 2024
@jenngra505 jenngra505 changed the title Invalid syntax in .def, .air, and.cns are ignored Invalid syntax in .def, .air, and.cns are ignored (Apparently accurate to Mugen) Nov 23, 2024
@potsmugen
Copy link
Contributor

potsmugen commented Nov 24, 2024

A few of those are because of the way the compiler works. After a code block header is found it looks for familiar lines respective to that block. It doesn't go over each individual line to see if they make sense, I think.

@K4thos K4thos added the etc Everything else label Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
etc Everything else
Projects
None yet
Development

No branches or pull requests

3 participants