Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift+F4 does not restart the music as in Mugen 1.1 #2178

Open
Kiwi1444 opened this issue Dec 10, 2024 · 5 comments
Open

Shift+F4 does not restart the music as in Mugen 1.1 #2178

Kiwi1444 opened this issue Dec 10, 2024 · 5 comments
Labels
feature port A feature from MUGEN that is not implemented. group: lua Problem with things handled by external scripts (screenpacks)

Comments

@Kiwi1444
Copy link

Describe the bug

Shift+F4 combination does not restart the music as in Mugen 1.1

To Reproduce

  1. Start the match on the stage with music
  2. Try to restart match with Shift+F4

Expected behavior

As in Mugen 1.1: Music restarts

Screenshots / Video

No response

Engine Version (or source code date)

Nightly 2024-11-28

Operating system

Windows

Extra context or search terms

No response

@K4thos K4thos added bug Something isn't working feature port A feature from MUGEN that is not implemented. group: lua Problem with things handled by external scripts (screenpacks) and removed bug Something isn't working labels Dec 10, 2024
@K4thos
Copy link
Member

K4thos commented Dec 10, 2024

this should be handled by the upcoming commit that moves music playback to zss

@beterhans
Copy link

I found it the same.

Music was decided at the game is loading not the stage is loading.
in order to change music, you need to restart ikemen.

another thing I found
if you are using 3D stage, music file can be loaded without path, just with the def file.
but if a 2D stage, music file must have full path, I really hope 2D stage will behaviour like 3D. can be used without a path.

@potsmugen
Copy link
Contributor

another thing I found if you are using 3D stage, music file can be loaded without path, just with the def file. but if a 2D stage, music file must have full path, I really hope 2D stage will behaviour like 3D. can be used without a path.

Are you sure it's only for 3D stages? Or is it just that 3D stages are the only ones that are Ikemen-exclusive and therefore can be distributed without the sound folder in the BGM path?

Music was decided at the game is loading not the stage is loading. in order to change music, you need to restart ikemen.

This is a very minor issue since it only happens when you're modifying things and reloading with shift F4. So is the issue in the title I suppose. For gameplay purposes you could pretend the debug keys don't exist.

@beterhans
Copy link

Are you sure it's only for 3D stages? Or is it just that 3D stages are the only ones that are Ikemen-exclusive and therefore can be distributed without the sound folder in the BGM path?

I don't have 2D Ikemen-exclusive stage. but I don't put music in sound folder, I always put music with the def file.
this make orginaze char, and stages easier.

stages/author_name/stage.def
stages/author_name/stage.mp3
stages/game_name/stage.def
stages/game_name/stage.mp3
char/POTS/character_name.def

if I move a stage to another folder i have to change def, but if can accept without path, I just need to move the file without edit the defs.

@potsmugen
Copy link
Contributor

potsmugen commented Jan 5, 2025

You'll always have to edit the def file because Mugen stages will have sound/ in the path 99% of the time.

I was actually working on some stuff while using Shift F4 to reload and it hit me: is it so bad that the music does not reload? It certainly makes such a development setup more comfortable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature port A feature from MUGEN that is not implemented. group: lua Problem with things handled by external scripts (screenpacks)
Projects
None yet
Development

No branches or pull requests

4 participants