Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raiden's Drop Kick special doesn't come out. #2235

Open
UrsoManso opened this issue Jan 7, 2025 · 2 comments
Open

Raiden's Drop Kick special doesn't come out. #2235

UrsoManso opened this issue Jan 7, 2025 · 2 comments
Labels
compatibility Engine differences group: input Problem related to how engine handles inputs wontfix This will not be worked on

Comments

@UrsoManso
Copy link

Describe the bug

His Drop Kick special(hold any kick button for at least 2 secs and then let go) doesn't work on Ikemen.

Tested on MUGEN 1.1 and it works just fine there.

To Reproduce

Download and add him to the latest Ikemen build. Raiden.zip

Expected behavior

His Drop Kick special to come out.

Screenshots / Video

No response

Engine Version (or source code date)

Nightly

Operating system

Windows

Extra context or search terms

No response

@potsmugen
Copy link
Contributor

potsmugen commented Jan 7, 2025

It looks like you found a new Mugen bug actually. New to me anyway.

Turns out Mugen can't buffer commands that are a single "hold" input. Probably a limitation or oversight in its input code.

We could probably add this limitation if the char doesn't have ikemenversion. But is it worth it? It took this long to find one char with this problem.

About the char in particular. At the top of the cmd file it has this:
command.buffer.time = 4
That means commands should be buffered for 4 frames unless specified otherwise.

Then you have these:

[Command]
name = "holda"
command = /a
time = 1
buffer.time = 1

[Command]
name = "holda"
command = /$a
time = 1

Notice how the second one lacks a buffer.time. In Ikemen it is buffered for 4 frames (the default set above) as you'd expect it, which breaks Drop Kick's charge code. In Mugen it won't be buffered at all because of this bug and the charge code will work.

About fixing the char: the cmd file has two sets of "holda", "holdb", etc commands. You can either delete the second set or add buffer.time = 1 to them like in the first set.

@K4thos K4thos added compatibility Engine differences group: input Problem related to how engine handles inputs wontfix This will not be worked on labels Jan 7, 2025
@UrsoManso
Copy link
Author

Interesting insight, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Engine differences group: input Problem related to how engine handles inputs wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants