Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error occurs when the number of enemies is more than 3 in tag mode #2302

Open
netyzh opened this issue Feb 4, 2025 · 5 comments
Open
Labels
compatibility Engine differences wontfix This will not be worked on

Comments

@netyzh
Copy link

netyzh commented Feb 4, 2025

Describe the bug

After defeating the first enemy, when you continue to attack the second one, some character's attack will lack hit sparks, and some moves will go awry.
It seems the problem happens when use codes enemy(0) and enemy(1).
However, versions in 0.99 or before the appearance of that config.ini should be normal.

To Reproduce

Character:https://www.mediafire.com/file/l1lsio682s0w8xl/Youmu.rar/file
Start a team versus
2p choose tag mode and select 4 character
Press 22d*2,do some damage,and press 26d to defeat first one
Continue to attack the second enemy.

Expected behavior

No response

Screenshots / Video

2025-02-04_13-38-17_x264.mp4

Engine Version (or source code date)

nightly

Operating system

Windows

Extra context or search terms

No response

@potsmugen
Copy link
Contributor

The char is hardcoded to play against 1 or 2 enemies. I'm surprised it worked before because this needs engine workarounds in several places to work. But even with those workarounds it did not work in the expanded Simul mode, which shows how much of a losing battle it is to do those.

It's an issue similar to #2238 and I maintain what I said there.

To fix the char you need to expand the limit of 2 enemies. That means replace:

  • NumEnemy = 2 with NumEnemy >= 2
  • Enemy(0) with EnemyNear(0)
  • Enemy(1) with EnemyNear(1)

It will still work in Mugen all the same.

@K4thos K4thos added wontfix This will not be worked on compatibility Engine differences labels Feb 4, 2025
@netyzh
Copy link
Author

netyzh commented Feb 4, 2025

Problem in #2238 also works well in previous version.
I think if we should handle the code for "enemy" and "enemynear" separately?The tag mode uses the code from previous versions, while the simul mode uses the current code. Would it solve the problem without requiring any changes to the character's own code?

@potsmugen
Copy link
Contributor

For this character, that would solve Tag but not Simul. But doesn't it sound confusing just to think about that? The priority should be having an engine that makes sense rather than one where no Mugen character needs to be modified under any circumstances, in my opinion.

@netyzh
Copy link
Author

netyzh commented Feb 4, 2025

At least we can try to handle the part of #2238 better. This issue still seems to exist, and it cannot be simply resolved by modifying the character's code.Unless directly avoid using helpers to handle variables,this change can be significant or minor.

@potsmugen
Copy link
Contributor

it cannot be simply resolved by modifying the character's code

Most things can. It's probably some variation of what I said above, if not the same. I can take a closer look if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Engine differences wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants