Skip to content

Commit 93c9d35

Browse files
authored
[12.x] remove @return docblocks on constructors (#55076)
* remove `@return` docblocks on constructors PHP constructors don't really return anything, so the docblock is kind of unnecessary. this also brings consistency since we have some that use the tag and some that do not. we have a total of 557 constructors in the framework, so we definitely used it more than we didn't, but my personal opinion is this direction makes more sense. https://docs.phpdoc.org/guide/references/phpdoc/tags/return.html#return laravel/framework#702 https://www.php.net/manual/en/language.oop5.decon.php * minor formatting * minor formatting
1 parent 57d7863 commit 93c9d35

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

ContextualBindingBuilder.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ class ContextualBindingBuilder implements ContextualBindingBuilderContract
3333
*
3434
* @param \Illuminate\Contracts\Container\Container $container
3535
* @param string|array $concrete
36-
* @return void
3736
*/
3837
public function __construct(Container $container, $concrete)
3938
{

RewindableGenerator.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ class RewindableGenerator implements Countable, IteratorAggregate
2727
*
2828
* @param callable $generator
2929
* @param callable|int $count
30-
* @return void
3130
*/
3231
public function __construct(callable $generator, $count)
3332
{

0 commit comments

Comments
 (0)